From: Pavel Machek <pavel@suse.cz>
To: schierlm@gmx.de
Cc: fr@canb.auug.org.au, linux-laptop@vger.kernel.org,
linux-kernel@vger.kernel.org, mochel@digitalimplant.org
Subject: Re: [PATCH] [APM] Is this the correct way to fix suspend bug introduced in 2.6.0-test4?
Date: Wed, 28 Jan 2004 18:46:55 +0100 [thread overview]
Message-ID: <20040128174655.GE1200@elf.ucw.cz> (raw)
In-Reply-To: <13zy7qdcyz1q7$.50e5l3rpbsyx$.dlg@40tude.net>
Hi!
>
> the patch below (against 2.6.1-mm5) fixes my APM problems (my laptop, Acer
> TravelMate 210TEV (Celeron 700, 128 MB RAM), hangs after resuming from APM
> since 2.6.0-test4).
>
> I found the "fix" by trying to "reversely" backport the changes from
> patch-2.6.0-test4.bz2 into 2.6.1-mm5 (the old device_suspend code calls
> sysdev_suspend, the new one does not; so what do I lose if I call
> sysdev_suspend myself?). This trial-and-error-approach finally led into the
> patch below (which works great for me).
>
> Most likely this is not the cleanest way to do this; but since I don't even
> know what this sysdev_suspend does (except that it does something that
> seems to be vital for making my laptop resume...), i don't know how to make
> it better...
>
> If you have any suggestions, tell me (or change it yourself and submit it),
> if you think that's okay like that, please submit that to the guy who is
> responsible for 2.6 (is it Linus or Andrew? did not follow lkml
> recently).
Andrew.
I think you should use device_power_down() and device_power_up(),
instead. Check it, but it looks to me like that's better way.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2004-01-28 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-25 19:50 [PATCH] [APM] Is this the correct way to fix suspend bug introduced in 2.6.0-test4? Michael Schierl
2004-01-28 17:46 ` Pavel Machek [this message]
2004-01-29 19:10 ` Michael Schierl
2004-01-29 19:36 ` Michael Schierl
2004-01-29 19:55 ` Pavel Machek
2004-01-29 23:00 ` Axel Boldt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040128174655.GE1200@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=fr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-laptop@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=schierlm@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.