From: Tim Hockin <thockin@sun.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: NGROUPS 2.6.2rc2
Date: Wed, 28 Jan 2004 14:22:25 -0800 [thread overview]
Message-ID: <20040128222225.GH9155@sun.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0401281007420.27790@home.osdl.org>
On Wed, Jan 28, 2004 at 10:10:02AM -0800, Linus Torvalds wrote:
> Although I do believe that it would be better written as
>
> #define MAXGROUPS (1000) /* Arbitrary, but we have to limit it somehere */
>
> if ((unsigned) info->ngroups > MAXGROUPS)
> return -ETOOEFFINGLARGE;
>
> as I absolutely _despise_ code that tries to be too generic.
>
> What is it with CS classes that have removed "common sense" from the
> equation?
OK, there are two easy answers to this. I can re-work it with a simple 32k
limit that needs to be recompiled to change, or I can add a sysctl to
control it (it appeared in an early version of this patch).
Preference?
--
Tim Hockin
Sun Microsystems, Linux Software Engineering
thockin@sun.com
All opinions are my own, not Sun's
next prev parent reply other threads:[~2004-01-28 22:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-27 22:53 NGROUPS 2.6.2rc2 Tim Hockin
2004-01-27 23:25 ` Dax Kelson
2004-01-27 23:55 ` Chris Wright
2004-01-28 0:41 ` Chris Wright
2004-01-28 0:46 ` Andrew Morton
2004-01-28 0:52 ` Christoph Hellwig
2004-01-28 1:02 ` Tim Hockin
2004-01-28 17:08 ` Hugh Dickins
2004-01-28 18:04 ` Hugh Dickins
2004-01-28 18:10 ` Linus Torvalds
2004-01-28 22:22 ` Tim Hockin [this message]
2004-02-03 22:17 ` Pavel Machek
2004-02-04 22:11 ` Panu Matilainen
2004-01-28 1:12 ` Rusty Russell
2004-01-28 11:31 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040128222225.GH9155@sun.com \
--to=thockin@sun.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.