From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] - Improve SN2 TLB flushing algorithms
Date: Thu, 29 Jan 2004 13:40:38 +0000 [thread overview]
Message-ID: <20040129134037.A9040@infradead.org> (raw)
In-Reply-To: <20040128205912.GA27401@sgi.com>
On Wed, Jan 28, 2004 at 04:36:01PM -0600, Jack Steiner wrote:
> Are you suggesting that we remove the #ifdef OR hide the code
> in a function that, depending on config options, may or may not do anything?
Yes. And I wonder whether we should just do it unconditionally, but
I'm not really sure.
> > > + if (!cpu_isset(smp_processor_id(), mm->cpu_vm_mask))
> > > + cpu_set(smp_processor_id(), mm->cpu_vm_mask);
> >
> > cpu_test_and_set()?
>
> On IA64 (not sure about other architectures), cpu_test_and_set will always
> set the bit regardless of it's previous state. That causes the cacheline containing
> the bitmask to be bounced between cpus - possibly unnecessarily. For most
Ok.
next prev parent reply other threads:[~2004-01-29 13:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-28 20:59 [PATCH] - Improve SN2 TLB flushing algorithms Jack Steiner
2004-01-28 21:17 ` Christoph Hellwig
2004-01-28 22:36 ` Jack Steiner
2004-01-28 23:57 ` Peter Chubb
2004-01-29 0:38 ` David Mosberger
2004-01-29 1:13 ` Jack Steiner
2004-01-29 3:11 ` Matthew Wilcox
2004-01-29 4:00 ` Jack Steiner
2004-01-29 13:40 ` Christoph Hellwig [this message]
2004-01-29 17:07 ` Jesse Barnes
2004-01-29 22:56 ` Jack Steiner
2004-01-29 23:09 ` Jesse Barnes
2004-01-30 2:22 ` Jack Steiner
2004-02-05 21:12 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040129134037.A9040@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.