From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Tim Hockin <thockin@sun.com>
Cc: Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
akpm@osld.org.sun.com
Subject: Re: PATCH - NGROUPS 2.6.2rc2 + fixups
Date: Fri, 30 Jan 2004 13:09:28 +1100 [thread overview]
Message-ID: <20040130021802.AA5BC2C0BF@lists.samba.org> (raw)
In-Reply-To: Your message of "Thu, 29 Jan 2004 11:41:31 -0800." <Pine.LNX.4.58.0401291138390.689@home.osdl.org>
In message <Pine.LNX.4.58.0401291138390.689@home.osdl.org> you write:
>
>
> On Thu, 29 Jan 2004, Tim Hockin wrote:
> >
> > What think?
>
> I still don't understand the complexity.
>
> Why the list of pages? Is there really any valid use for this that could
> overflow a simple "kmalloc()"? How many groups do people really really
> need?
I was happy with kmalloc, and no sorting. Simple patch. Tim
complained that he had some wierd-ass users who hit kmalloc limits w/
fragmentation. I added about 10 lines of code to fall back to vmalloc
for that very rare case, and you scotched that.
ie. Don't blame Tim: you led us here 8(
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2004-01-30 2:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-29 19:25 PATCH - NGROUPS 2.6.2rc2 + fixups Tim Hockin
2004-01-29 19:41 ` Linus Torvalds
2004-01-30 2:09 ` Rusty Russell [this message]
2004-02-09 11:38 ` Stefan Voelkel
2004-02-10 4:26 ` Mike Fedyk
2004-02-19 19:34 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040130021802.AA5BC2C0BF@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=thockin@sun.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.