From: "David S. Miller" <davem@redhat.com>
To: ultralinux@vger.kernel.org
Subject: Re: Problem with ioctl(fd, TUNSETIFF, ...)
Date: Mon, 02 Feb 2004 00:12:58 +0000 [thread overview]
Message-ID: <20040201161258.361538b2.davem@redhat.com> (raw)
On Fri, 30 Jan 2004 11:21:46 -0800
Eric Brower <ebrower@usa.net> wrote:
> The definition of TUNSETIF is:
>
> #define TUNSETIFF _IOW('T', 202, int)
>
> indicating the argument is an "int" rather than a "struct ifreq*". This
> trickery (as I understand it) would work on 32-bit systems, but not
> 64-bit.
Good spotting Eric, this should fix it in 2.4.x
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1306 -> 1.1307
# arch/sparc64/kernel/ioctl32.c 1.45 -> 1.46
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/02/01 davem@nuts.davemloft.net 1.1307
# [SPARC64]: Fix TUNSETIFF ioctl compat, it takes an ifreq ptr not an int.
#
# Thanks to Eric Brower for spotting this.
# --------------------------------------------
#
diff -Nru a/arch/sparc64/kernel/ioctl32.c b/arch/sparc64/kernel/ioctl32.c
--- a/arch/sparc64/kernel/ioctl32.c Sun Feb 1 16:08:53 2004
+++ b/arch/sparc64/kernel/ioctl32.c Sun Feb 1 16:08:53 2004
@@ -4524,7 +4524,6 @@
/* Big T */
COMPATIBLE_IOCTL(TUNSETNOCSUM)
COMPATIBLE_IOCTL(TUNSETDEBUG)
-COMPATIBLE_IOCTL(TUNSETIFF)
COMPATIBLE_IOCTL(TUNSETPERSIST)
COMPATIBLE_IOCTL(TUNSETOWNER)
/* Big V */
@@ -5146,6 +5145,7 @@
HANDLE_IOCTL(SIOCGIFPFLAGS, dev_ifsioc)
HANDLE_IOCTL(SIOCGIFTXQLEN, dev_ifsioc)
HANDLE_IOCTL(SIOCSIFTXQLEN, dev_ifsioc)
+HANDLE_IOCTL(TUNSETIFF, dev_ifsioc)
HANDLE_IOCTL(SIOCETHTOOL, ethtool_ioctl)
HANDLE_IOCTL(SIOCBONDENSLAVE, bond_ioctl)
HANDLE_IOCTL(SIOCBONDRELEASE, bond_ioctl)
next reply other threads:[~2004-02-02 0:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-02 0:12 David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-01-30 19:21 Problem with ioctl(fd, TUNSETIFF, ...) Eric Brower
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040201161258.361538b2.davem@redhat.com \
--to=davem@redhat.com \
--cc=ultralinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.