From: "David S. Miller" <davem@redhat.com>
To: sparclinux@vger.kernel.org
Subject: Re: [sparc32] Copy full soft PMD in fault handler
Date: Mon, 02 Feb 2004 18:22:57 +0000 [thread overview]
Message-ID: <20040202102257.24b70263.davem@redhat.com> (raw)
In-Reply-To: <20040202094347.GB22498@foobazco.org>
On Mon, 2 Feb 2004 01:43:47 -0800
Keith M Wesolowski <wesolows@foobazco.org> wrote:
> sparc_do_fault assumes that pmd_val(*pmd) = pmd_val(*pmd_k) will
> duplicate a PMD entry. With large soft-PMDs this doesn't work.
>
> Is this ok?
I think this patch is just fine.
> The comment in the i386 handler "Do _not_
> use "tsk" here. We might be inside an interrupt in the middle of a
> task switch.." doesn't make me feel too good about this function's
> health and well-being either, since we use tsk.
I think it does not apply to sparc, on sparc we disable interrupts during
the context switch so that it "appears" atomic. But actually you should
change it over to use init_mm.pgd just like other platforms merely for
consistency.
prev parent reply other threads:[~2004-02-02 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-02 9:43 [sparc32] Copy full soft PMD in fault handler Keith M Wesolowski
2004-02-02 18:22 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040202102257.24b70263.davem@redhat.com \
--to=davem@redhat.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.