From: Mark Fasheh <mark.fasheh@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] RE: [Ocfs2-users] RE: Playing with OCFS2
Date: Mon Feb 2 17:59:19 2004 [thread overview]
Message-ID: <20040202235907.GA25263@ca-server1.us.oracle.com> (raw)
In-Reply-To: <50D19C3AC815734C9E19FE4C4F6128A602A56872@orsmsx403.jf.intel.com>
Ahh, good catch! I removed those lines of code as that check is not really
needed (it's simple enough to follow). Thanks!
--Mark
On Mon, Feb 02, 2004 at 03:13:39PM -0800, Villalovos, John L wrote:
> Enclosed please find a patch which fixes the issue I had.
>
> The root cause is that spin_trylock will always return 1 on a
> Uniprocessor (UP) system.
>
> It appears the code in this case had an assumption of a SMP system. The
> spin_trylock appears to be used as a debugging mechanism to make sure
> that a lock had been previously made before the function was called.
>
> My patch is just to use the #ifdef CONFIG_SMP but I think that this may
> go against the kernel guidelines but I am not sure.
>
> John
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
Mark Fasheh
Software Developer, Oracle Corp
mark.fasheh@oracle.com
next prev parent reply other threads:[~2004-02-02 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50D19C3AC815734C9E19FE4C4F6128A602A56872@orsmsx403.jf.intel.com >
2004-02-02 17:17 ` [Ocfs2-devel] RE: [Ocfs2-users] RE: Playing with OCFS2 Villalovos, John L
2004-02-02 17:59 ` Mark Fasheh [this message]
2004-02-02 13:53 Villalovos, John L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040202235907.GA25263@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.