From: "J. Bruce Fields" <bfields@fieldses.org>
To: linda.dunaphant@ccur.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.1 nfs4 mount version message
Date: Mon, 2 Feb 2004 21:50:41 -0500 [thread overview]
Message-ID: <20040203025040.GA11303@fieldses.org> (raw)
In-Reply-To: <200402030146.BAA22183@jedi.ccur.com>
On Mon, Feb 02, 2004 at 08:46:29PM -0500, Linda Dunaphant wrote:
> In the file fs/nfs/inode.c in nfs4_get_sb() there is a test that compares
> the version of the incoming nfs4_mount_data versus NFS4_MOUNT_VERSION. If
> these do not match, a warning message is printed. Inside the printk() for
> this warning message, there is another test of the versions to determine
> whether the string "older" or "newer" should be printed.
>
> Shouldn't this second test be comparing NFS4_MOUNT_VERSION instead of
> NFS_MOUNT_VERSION?
Whoops, yes.
> I have included a patch for linux-2.6.1.
Thanks.--Bruce Fields
> diff -ur base.linux-2.6.1/fs/nfs/inode.c new.linux-2.6.1/fs/nfs/inode.c
> --- base.linux-2.6.1/fs/nfs/inode.c 2004-01-09 01:59:55.000000000 -0500
> +++ new.linux-2.6.1/fs/nfs/inode.c 2004-01-30 15:47:55.000000000 -0500
> @@ -1499,7 +1499,7 @@
>
> if (data->version != NFS4_MOUNT_VERSION) {
> printk("nfs warning: mount version %s than kernel\n",
> - data->version < NFS_MOUNT_VERSION ? "older" : "newer");
> + data->version < NFS4_MOUNT_VERSION ? "older" : "newer"); }
>
> p = nfs_copy_user_string(NULL, &data->hostname, 256);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2004-02-03 2:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-03 1:46 [PATCH] 2.6.1 nfs4 mount version message Linda Dunaphant
2004-02-03 2:50 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040203025040.GA11303@fieldses.org \
--to=bfields@fieldses.org \
--cc=linda.dunaphant@ccur.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.