From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Randy.Dunlap" <rddunlap@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add syscalls.h
Date: Tue, 3 Feb 2004 14:29:16 -0600 [thread overview]
Message-ID: <20040203202916.GC31138@waste.org> (raw)
In-Reply-To: <20040201224344.43d1c37d.akpm@osdl.org>
On Sun, Feb 01, 2004 at 10:43:44PM -0800, Andrew Morton wrote:
> +extern asmlinkage long sys_unlink(const char __user *pathname);
> +extern asmlinkage long sys_chmod(const char __user *filename, mode_t mode);
> +extern asmlinkage long sys_fchmod(unsigned int fd, mode_t mode);
>
> Maybe lose the `extern' too. It's just a waste of space. I normally put
> it in for consistency if the surrounding code is done that way, but for a
> new header file, why bother?
I'd really like to see the extern go, if only to discourage that
particular bit of cargo cult programming. There are actually people
who think it serves a purpose..
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
next prev parent reply other threads:[~2004-02-03 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040130163547.2285457b.rddunlap@osdl.org>
2004-02-02 6:22 ` [PATCH] add syscalls.h Randy.Dunlap
2004-02-02 6:43 ` Andrew Morton
2004-02-03 20:29 ` Matt Mackall [this message]
2004-02-03 20:40 ` Richard B. Johnson
2004-02-03 21:18 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040203202916.GC31138@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.