All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] New guy here, and patch for kj.pl
Date: Thu, 05 Feb 2004 11:19:04 +0000	[thread overview]
Message-ID: <200402051219.05072.domen@coderock.org> (raw)
In-Reply-To: <20040125123747.GA21585@noos.fr>

On Thursday 05 of February 2004 11:20, Michael Veeck wrote:
> Hi! I'm another new guy here on kj and a few days ago I wrote a little
> patch to show that I want to tackle the removal of some unnecessary
> min/max-methods in the kernel.
>
> I didnt get any feedback yet, but I guess since nobody screamed (and I
> found some more occurences) I'm going to try my best.

No screaming is usually good :-)


<snipped some code that uses MAX in struct initializers>

> Can anyone help me with that error code?

The problem is struct initializers can't be code (max evaluates to some code, 
while MAX works fine, as the preprocessor does all the work).

In this case that MAX looks like the right thing, except for arguments used 
twice in #define.

Any better ideas than leaving this as it is now?


	Domen

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-02-05 11:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-25 12:37 [Kernel-janitors] New guy here, and patch for kj.pl JOUANNE Mickael
2004-02-04 18:34 ` Randy.Dunlap
2004-02-05 10:20 ` Michael Veeck
2004-02-05 11:19 ` Domen Puncer [this message]
2004-02-05 21:48 ` Randy.Dunlap
2004-02-05 21:50 ` Michael Veeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200402051219.05072.domen@coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.