All of lore.kernel.org
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: Linus Torvalds <torvalds@osdl.org>
Cc: John Cherry <cherry@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: IA32 (2.6.2 - 2004-02-05.22.30) - 3 New warnings (gcc 3.2.2)
Date: Fri, 6 Feb 2004 18:47:07 +0000	[thread overview]
Message-ID: <20040206184707.GL21151@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0402061041190.30672@home.osdl.org>

On Fri, Feb 06, 2004 at 10:42:00AM -0800, Linus Torvalds wrote:
> 
> 
> 
> On Fri, 6 Feb 2004 viro@parcelfarce.linux.theplanet.co.uk wrote:
> > 
> > Umm...  How about
> > 
> > static inline void BUG() __attribute__((noreturn));
> > 
> > static inline void BUG(void)
> > {
> > 	__asm__ ....
> > }
> 
> Did you try that? Last time I tried, gcc would complain every time it saw 
> the thing about "noreturn function does return".

So it does ;-/

Anyway, in both of those cases BUG() is gratitious.  What that code tries
to do is "if we decided to use one of the old modes, we'll need 3 ports;
otherwise we should claim 8".  So simple if() would be enough.  I'll send
a patch in a few.

It would be nice to have gcc understand that BUG() is a sink.  Oh, well...

  reply	other threads:[~2004-02-06 18:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-06 11:22 IA32 (2.6.2 - 2004-02-05.22.30) - 3 New warnings (gcc 3.2.2) John Cherry
2004-02-06 11:33 ` viro
2004-02-06 16:52   ` Linus Torvalds
2004-02-06 18:22     ` viro
2004-02-06 18:35       ` Petr Vandrovec
2004-02-06 18:42       ` Linus Torvalds
2004-02-06 18:47         ` viro [this message]
2004-02-06 19:09           ` viro
2004-02-10 13:32         ` Dick Streefland
2004-02-10 15:44           ` Randy.Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2004-02-08  1:00 Jon Foster
2004-02-08  5:45 ` viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040206184707.GL21151@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=cherry@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.