All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Linux Fbdev development list
	<linux-fbdev-devel@lists.sourceforge.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: fbdev sysfs support.
Date: Fri, 6 Feb 2004 17:15:44 -0800	[thread overview]
Message-ID: <20040207011544.GC4492@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0402070100420.19559-100000@phoenix.infradead.org>

On Sat, Feb 07, 2004 at 01:01:35AM +0000, James Simmons wrote:
> diff -urN -X /home/jsimmons/dontdiff linus-2.6/drivers/video/fbmem.c fbdev-2.6/drivers/video/fbmem.c
> --- linus-2.6/drivers/video/fbmem.c	2004-01-27 19:48:11.000000000 -0800
> +++ fbdev-2.6/drivers/video/fbmem.c	2004-02-06 03:45:53.000000000 -0800
> @@ -1228,6 +1228,9 @@
>  			break;
>  	fb_info->node = i;
>  	
> +	if (fb_add_class_device(fb_info))
> +		return -EINVAL;
> +	

Woah, what about all of the fb drivers that statically allocate their
fb_info structure?  This will die a horrible death for them when they
try to unload themselves.

Are you going to fix up every fb driver to call framebuffer_alloc() to
fix this problem?  That's quite a task...

thanks,

greg k-h

  parent reply	other threads:[~2004-02-07  1:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-07  0:34 fbdev sysfs support James Simmons
2004-02-07  0:59 ` Greg KH
2004-02-07  1:01   ` James Simmons
2004-02-07  1:10     ` viro
2004-02-07  1:19       ` Greg KH
2004-02-07  1:22         ` viro
2004-02-07  1:23         ` James Simmons
2004-02-07  1:28           ` Greg KH
2004-02-07  1:31             ` viro
2004-02-07  1:29           ` viro
2004-02-07  1:29             ` viro
2004-02-07  1:15     ` Greg KH [this message]
2004-02-07  1:24       ` viro
2004-02-07  1:23     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040207011544.GC4492@kroah.com \
    --to=greg@kroah.com \
    --cc=jsimmons@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.