From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264542AbUBIBab (ORCPT ); Sun, 8 Feb 2004 20:30:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264546AbUBIBaa (ORCPT ); Sun, 8 Feb 2004 20:30:30 -0500 Received: from waste.org ([209.173.204.2]:21173 "EHLO waste.org") by vger.kernel.org with ESMTP id S264542AbUBIBaU (ORCPT ); Sun, 8 Feb 2004 20:30:20 -0500 Date: Sun, 8 Feb 2004 19:29:51 -0600 From: Matt Mackall To: Tom Rini Cc: Pavel Machek , akpm@osdl.org, george@mvista.com, amitkale@emsyssoft.com, Andi Kleen , jim.houston@comcast.net, Kernel Mailing List Subject: Re: BitKeeper repo for KGDB Message-ID: <20040209012951.GE2315@waste.org> References: <20040127184029.GI32525@stop.crashing.org> <20040128165104.GC1200@elf.ucw.cz> <20040128170520.GI6577@stop.crashing.org> <20040128174402.GI340@elf.ucw.cz> <20040128175646.GJ6577@stop.crashing.org> <20040206223517.GD5219@smtp.west.cox.net> <20040206225535.GB539@elf.ucw.cz> <20040206230254.GE5219@smtp.west.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040206230254.GE5219@smtp.west.cox.net> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 06, 2004 at 04:02:54PM -0700, Tom Rini wrote: > On Fri, Feb 06, 2004 at 11:55:35PM +0100, Pavel Machek wrote: > > Hi! > > > > > > > It's against 2.6 + -netpoll + Amit's patch. > > > > > > > > But doesn't -mm have a kgdb over enet driver that does work? It's just > > > > not been ported to Amit's bits, right? > > > > > > OK. Based on this, and some other fixes, I've pushed my first cut of > > > KGDB over ethernet. It's not quite as robust as I'd like right now (I'm > > > still getting it just-right for connecting live), and I've got some not > > > quite finished improvements still locally, but it does work. > > > > Is there way to get plain diff (against -mm or against Amit or > > something?) > > I'll post a diff against -mm next week when I'm a bit happier with it, > but the following is against Amit's version + your patch to port it to > netpoll: > if (!netpoll_trap() && len == 8 && !strncmp(msg, "$Hc-1#09", 8)) > - printk(KERN_CRIT "Someone is trying to attach\n"); > -// kgdb_schedule_breakpoint(); > + breakpoint(); > > for (i = 0; i < len; i++) { > - if (msg[i] == 3) /* Check for ^C? */ > - printk(KERN_CRIT "Someone is trying to ^C?\n"); > -// kgdb_schedule_breakpoint(); > + if (msg[i] == 3) > + breakpoint(); The kgdb_schedule_breakpoint stuff in -mm didn't just appear to make things more complicated, it is in fact necessary. You cannot reasonably expect to break deep inside the network stack IRQ handler and then send more packets out the same interface. Expect especially nasty results on SMP. It only works for the serial case because that path is a priori known to be lockless. -- Matt Mackall : http://www.selenic.com : Linux development and consulting