From: "David S. Miller" <davem@redhat.com>
To: yoshfuji@linux-ipv6.org
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH,RFC] [NET] ALIGN
Date: Mon, 9 Feb 2004 11:20:07 -0800 [thread overview]
Message-ID: <20040209112007.08023ba6.davem@redhat.com> (raw)
In-Reply-To: <20040209.134528.28683257.yoshfuji@linux-ipv6.org>
On Mon, 09 Feb 2004 13:45:28 +0900 (JST)
YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> wrote:
> D: Use ALIGN() where appricable.
>
> BTW,
> 1. do we really need this ALIGN?
> 2. should 16 be BYTES_PER_WORD (in mm/slab.c)?
Let's hold on this patch.
Why does it want to align the table entry size to 16 bytes
anyways?
I think this is complete nonsense, and that the alignment is not
necessary. I can't even come up with a performance reason as SLAB
is going to align things to hw cache line size anyways.
Can anybody come up with some theory ? :-)
Else let's just remove this bogus 16 byte alignment in the
kmem_cache_create() call.
next prev parent reply other threads:[~2004-02-09 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-09 4:45 [PATCH,RFC] [NET] ALIGN YOSHIFUJI Hideaki / 吉藤英明
2004-02-09 19:20 ` David S. Miller [this message]
2004-02-10 4:05 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-11 18:42 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040209112007.08023ba6.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.