Re: [PATCH 2.6] powernow-k7 acpi support.

[Dominik Brodowski <linux@dominikbrodowski.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1814 bytes --]

> 1- Include the powernow_acpi_init() as the first call in
> powernow_decode_bios(), so that ACPI is used first, then if it failed,
> the legacy method is used,
> or
> 2- Include the powernow_acpi_init() at powernow_decode_bios() just
> before the 3 printk's stating to write that you should see
> http://www.codemonkey.org.uk/projects/cpufreq/...
> 
> I guess 2- is 'better', but I would like to get some thought, though.

Hm. That's difficult to decide, also for the speedstep-centrino case... I'd
like to hear some opinions from ACPI and AMD guys first before we decide...

> +	printk("1\n");
> +	if (acpi_processor_register_performance(&p, 0))
> +		return -EIO;
> +	printk("2\n");
> +
> +	r = &p.control_register;
> +	if (r->space_id != ACPI_ADR_SPACE_FIXED_HARDWARE) {

How about
	if (p.control_register.space_id != ACPI_ADR_SPACE_FIXED_HARDWARE) {
?

> +		retval = -ENODEV;
> +		goto out;
> +	}
> +	r = &p.status_register;
> +	if (r->space_id != ACPI_ADR_SPACE_FIXED_HARDWARE) {

same here...

> +	fsb = 100;	/* XXX fix me */

Any idea on how to determine the FSB?

> +	latency = 10000;	/* XXX don't trust bios writers.. */

heh...

> +	/*
> +	 * We don't need no more acpi.
> +	 * XXX is that true?
> +	 */

No, it's not true. If we use ACPI, we need to keep it registered until we
stop using it. Reasons:
- keep buggy drivers from interfering [e.g. other cpufreq drivers which 
  register with ACPI first and with cpufreq later, or avoid registering with
  cpufreq because of being proprietary...]
- honor _PPC limits
- allow for ACPI interface (additions):
  This includes the /proc/acpi/processor/./performance interface which
  people still tend to use, and additions to 
  /sys/devices/system/cpu/cpu0/cpufreq/ still to be written.


	Dominik

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@www.linux.org.uk
http://www.linux.org.uk/mailman/listinfo/cpufreq