From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: linux-mips@linux-mips.org
Subject: Re: [patch] dump_tlb.c clean-ups
Date: Tue, 10 Feb 2004 17:34:07 +0100 [thread overview]
Message-ID: <20040210163407.GA30617@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.55.0402101653290.6769@jurand.ds.pg.gda.pl>
On Tue, Feb 10, 2004 at 05:15:39PM +0100, Maciej W. Rozycki wrote:
> Ralf,
>
> Gcc 3.4 complains about a possibly undefined operation in dump16() in
> arch/mips/lib/r3k_dump_tlb.c. The following patch fixes it. I've taken
> the opportunity to clean up the file and its counterparts thus:
>
> 1. I've cast the pointers to "unsigned long" consistently for output
> formatting as the width specifier doesn't work very well with pointers.
>
> 2. I've renamed msg2str() to msk2str() in one of the variations.
>
> 3. I've reordered header inclusions in one of the variations.
>
> 4. I've fixed indentation throughout, perhaps not completely, but still
> the result should be somewhat closer to sanity.
>
> These changes make the three variations closer to one another where
> possible.
>
> OK to apply?
Sure, go ahead.
I guess the output format could also use some improvments for readability ...
Ralf
prev parent reply other threads:[~2004-02-10 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 16:15 [patch] dump_tlb.c clean-ups Maciej W. Rozycki
2004-02-10 16:34 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040210163407.GA30617@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@ds2.pg.gda.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.