All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: netdev@oss.sgi.com, linux-net@vger.kernel.org
Subject: Re: Restrict local IP announcements in ARP requests
Date: Wed, 11 Feb 2004 20:16:56 -0800	[thread overview]
Message-ID: <20040211201656.4e4f708e.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0402100251380.1251@u.domain.uli>

On Tue, 10 Feb 2004 03:00:24 +0200 (EET)
Julian Anastasov <ja@ssi.bg> wrote:

> 	If you like it in this way you can apply now or after
> some days or to delay it if we want to combine it with other
> device flags or changes.

I like the patch, but I want the documentation changed.

If you'll recall, one of the big problems Alexey and myself
had with the new ARP saddr selection behavior you propose is
that it assumes that: if we do not know of a certain subnet
being on a link than this subnet does not exist there.

In some environments this assumption holds.  But "some != all"
as I often say to a friend of mine :-)

No router has this knowledge completely, and in many environments
such an assumption does not hold.

I know you understand this, which is why your patch keeps the
current behavior the default.

But I want the docs for the sysctl to talk about this.  Something
simple like:

+	1 - Try to avoid local addresses that are not in the target's
+	subnet for this interface as far as we know.  In some environments
+	subnets may be active that this system is not aware of, thus this
+	setting might cause problems in such cases.

Tweak it however you wish, just get the idea/warning across.

I'd also prefer if you at least lightly define what "best" source address
means in the context of arp_announce==2.

Thanks.

  reply	other threads:[~2004-02-12  4:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-08  9:59 Restrict local IP announcements in ARP requests Julian Anastasov
2004-02-09 22:08 ` David S. Miller
2004-02-09 22:20   ` David S. Miller
2004-02-09 23:06   ` Julian Anastasov
2004-02-09 23:10     ` David S. Miller
2004-02-10  0:31       ` Julian Anastasov
2004-02-12  4:22         ` David S. Miller
2004-02-15 10:04           ` Julian Anastasov
2004-02-18  3:07             ` David S. Miller
2004-02-18  8:22               ` Julian Anastasov
2004-02-18 21:03                 ` David S. Miller
2004-02-10  1:00       ` Julian Anastasov
2004-02-12  4:16         ` David S. Miller [this message]
2004-02-12 23:50           ` Julian Anastasov
2004-02-14  7:24             ` David S. Miller
2004-02-14 12:03               ` Julian Anastasov
2004-02-14 20:37                 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040211201656.4e4f708e.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=ja@ssi.bg \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.