All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@convergence.de>
To: Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] bogus __KERNEL_SYSCALLS__ usage
Date: Thu, 12 Feb 2004 20:31:38 +0100	[thread overview]
Message-ID: <20040212193137.GE28768@convergence.de> (raw)
In-Reply-To: <20040212162856.GU12634@redhat.com>

Dave Jones wrote:
> I just did a mini-audit of users of __KERNEL_SYSCALLS and turned
> up a bunch of uglies. The patch below is the easy ones
> (nothing to fix, they were defining it and including unistd.h for no reason).
> The remainders will need more work.
...
> 	drivers/media/dvb/frontends/tda1004x.c:#define __KERNEL_SYSCALLS__
> 	drivers/media/dvb/frontends/sp887x.c:#define __KERNEL_SYSCALLS__
> 	drivers/media/dvb/frontends/alps_tdlb7.c:#define __KERNEL_SYSCALLS__
> 
> Joy joy. Implementing their own firmware loaders by directly
> reading files into kernel space. Icky.

Old code, implemented before request_firmware() existed.

The problem is that the current dvb_i2c stuff has no direct access
to a sysfs struct device, which is necessary for request_firmware().
Possible solutions have briefly been discussed on the linux-dvb list,
one of them ditching dvb_i2c in favor of the kernel i2c subsystem.

So please be patient, work is under way. See also
Documentation/dvb/firmware.txt.


Johannes

  reply	other threads:[~2004-02-12 19:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-12 16:28 [PATCH] bogus __KERNEL_SYSCALLS__ usage Dave Jones
2004-02-12 19:31 ` Johannes Stezenbach [this message]
2004-02-12 21:43 ` Andrew Morton
2004-02-12 22:01   ` Dave Jones
2004-02-12 21:45 ` David Mosberger
  -- strict thread matches above, loose matches on Subject: below --
2004-02-12 22:16 Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040212193137.GE28768@convergence.de \
    --to=js@convergence.de \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.