From: Manish Singh <manish.singh@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Request to remove -Wfno-format
Date: Fri Feb 13 16:15:41 2004 [thread overview]
Message-ID: <20040213221537.GA15067@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20040213054330.GA12076@penguin.co.intel.com>
On Thu, Feb 12, 2004 at 09:43:30PM -0800, Rusty Lynch wrote:
> On Thu, Feb 12, 2004 at 07:44:34PM -0800, Manish Singh wrote:
> > On Thu, Feb 12, 2004 at 05:52:01PM -0800, Rusty Lynch wrote:
> > > (There are a couple of places where I cast a size_t to int to stop warnings
> > > on 64bit machines... can't think of a cleaner way of printing size_t since
> > > prink doesn't directly handle the type.)
> >
> > %Zu works for size_t.
>
> Ah.. I see that now in the fprintf man page.
>
> Here is another version of the patch that uses %zu where appropriate.
Well, I really meant "%Zu". 'z' is a modifier that was introduced in C99,
but it's only in very recent 2.4.x printk implementations, i.e. none of
current AS 2.1, EL3, or UL have it, which means we can't use it. 'Z' is
GNU extension (that's deprecated now in favor of the C99 modifier) that
*is* in all the printks we need to support, so we should use that.
__attribute__ format should know about both anyway.
BTW, are you planning on replacing HI/LO with %L in a later patch?
-Manish
next prev parent reply other threads:[~2004-02-13 16:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-12 12:39 [Ocfs2-devel] Request to remove -Wfno-format Rusty Lynch
2004-02-12 12:52 ` Rusty Lynch
2004-02-12 14:30 ` Manish Singh
2004-02-13 16:10 ` Rusty Lynch
2004-02-12 21:44 ` Manish Singh
2004-02-13 16:10 ` Rusty Lynch
2004-02-13 16:15 ` Manish Singh [this message]
2004-02-13 16:24 ` Rusty Lynch
2004-02-13 18:07 ` Rusty Lynch
2004-02-13 19:04 ` Manish Singh
2004-02-13 19:37 ` Rusty Lynch
2004-02-13 21:05 ` Manish Singh
2004-02-13 21:09 ` Rusty Lynch
2004-02-13 21:18 ` Mark Fasheh
2004-02-16 15:01 ` Rusty Lynch
-- strict thread matches above, loose matches on Subject: below --
2004-02-17 8:50 Cahill, Ben M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040213221537.GA15067@ca-server1.us.oracle.com \
--to=manish.singh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.