All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugene Teo <eugene.teo@eugeneteo.net>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: VM Acct patch (was Re: 2.6.3-rc1-mm1)
Date: Sat, 14 Feb 2004 10:04:49 +0800	[thread overview]
Message-ID: <20040214020449.GA2252@eugeneteo.net> (raw)
In-Reply-To: <20040209014035.251b26d1.akpm@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 3788 bytes --]

<quote sender="Andrew Morton">
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.3-rc1/2.6.3-rc1-mm1/

[snipped]

While doing my port, I noticed that add_page_state macro can be used
in place of mod_page_state, since both performs the same task, and the
former is more meaningful.

Here my patch. It applies to 2.6.3-rc2-mm1, but it shouldn't matter if
-rc2 or -rc2-mm1 is applied. I have compiled this patch, and tested it
too.

http://www.anomalistic.org/patches/vmacct-mod_page_state-fix-2.6.3-rc2-mm1.patch

diff -Naur -X /home/amnesia/w/dontdiff 2.6.3-rc2-mm1-BAK/drivers/block/ll_rw_blk.c 2.6.3-rc2-mm1-fix/drivers/block/ll_rw_blk.c
--- 2.6.3-rc2-mm1-BAK/drivers/block/ll_rw_blk.c	2004-02-14 09:36:28.000000000 +0800
+++ 2.6.3-rc2-mm1-fix/drivers/block/ll_rw_blk.c	2004-02-14 09:40:43.000000000 +0800
@@ -2313,9 +2313,9 @@
 	BIO_BUG_ON(!bio->bi_io_vec);
 	bio->bi_rw = rw;
 	if (rw & WRITE)
-		mod_page_state(pgpgout, count);
+		add_page_state(pgpgout, count);
 	else
-		mod_page_state(pgpgin, count);
+		add_page_state(pgpgin, count);
 
 	if (unlikely(block_dump)) {
 		char b[BDEVNAME_SIZE];
diff -Naur -X /home/amnesia/w/dontdiff 2.6.3-rc2-mm1-BAK/fs/inode.c 2.6.3-rc2-mm1-fix/fs/inode.c
--- 2.6.3-rc2-mm1-BAK/fs/inode.c	2004-02-14 09:36:30.000000000 +0800
+++ 2.6.3-rc2-mm1-fix/fs/inode.c	2004-02-14 09:44:57.000000000 +0800
@@ -453,9 +453,9 @@
 	up(&iprune_sem);
 
 	if (current_is_kswapd())
-		mod_page_state(kswapd_inodesteal, reap);
+		add_page_state(kswapd_inodesteal, reap);
 	else
-		mod_page_state(pginodesteal, reap);
+		add_page_state(pginodesteal, reap);
 }
 
 /*
diff -Naur -X /home/amnesia/w/dontdiff 2.6.3-rc2-mm1-BAK/mm/page_alloc.c 2.6.3-rc2-mm1-fix/mm/page_alloc.c
--- 2.6.3-rc2-mm1-BAK/mm/page_alloc.c	2004-02-14 09:36:30.000000000 +0800
+++ 2.6.3-rc2-mm1-fix/mm/page_alloc.c	2004-02-14 09:42:01.000000000 +0800
@@ -268,7 +268,7 @@
 	LIST_HEAD(list);
 	int i;
 
-	mod_page_state(pgfree, 1 << order);
+	add_page_state(pgfree, 1 << order);
 	for (i = 0 ; i < (1 << order) ; ++i)
 		free_pages_check(__FUNCTION__, page + i);
 	list_add(&page->list, &list);
@@ -512,7 +512,7 @@
 
 	if (page != NULL) {
 		BUG_ON(bad_range(zone, page));
-		mod_page_state(pgalloc, 1 << order);
+		add_page_state(pgalloc, 1 << order);
 		prep_new_page(page, order);
 	}
 	return page;
diff -Naur -X /home/amnesia/w/dontdiff 2.6.3-rc2-mm1-BAK/mm/vmscan.c 2.6.3-rc2-mm1-fix/mm/vmscan.c
--- 2.6.3-rc2-mm1-BAK/mm/vmscan.c	2004-02-14 09:36:30.000000000 +0800
+++ 2.6.3-rc2-mm1-fix/mm/vmscan.c	2004-02-14 09:45:09.000000000 +0800
@@ -460,10 +460,10 @@
 	list_splice(&ret_pages, page_list);
 	if (pagevec_count(&freed_pvec))
 		__pagevec_release_nonlru(&freed_pvec);
-	mod_page_state(pgsteal, ret);
+	add_page_state(pgsteal, ret);
 	if (current_is_kswapd())
-		mod_page_state(kswapd_steal, ret);
-	mod_page_state(pgactivate, pgactivate);
+		add_page_state(kswapd_steal, ret);
+	add_page_state(pgactivate, pgactivate);
 	return ret;
 }
 
@@ -535,7 +535,7 @@
 		if (nr_taken == 0)
 			goto again;
 
-		mod_page_state(pgscan, nr_scan);
+		add_page_state(pgscan, nr_scan);
 		nr_freed = shrink_list(&page_list, gfp_mask, nr_scanned);
 		ret += nr_freed;
 
@@ -784,8 +784,8 @@
 	spin_unlock_irq(&zone->lru_lock);
 	pagevec_release(&pvec);
 
-	mod_page_state(pgrefill, nr_pages_in - nr_pages);
-	mod_page_state(pgdeactivate, pgdeactivate);
+	add_page_state(pgrefill, nr_pages_in - nr_pages);
+	add_page_state(pgdeactivate, pgdeactivate);
 }
 
 /*

-- 
Eugene TEO -  <eugeneteo%eugeneteo!net>   <http://www.anomalistic.org/>
1024D/14A0DDE5 print D851 4574 E357 469C D308  A01E 7321 A38A 14A0 DDE5
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      parent reply	other threads:[~2004-02-14  2:04 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-09  9:40 2.6.3-rc1-mm1 Andrew Morton
2004-02-09  9:40 ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-09  9:50 ` 2.6.3-rc1-mm1 Stian Jordet
2004-02-09  9:50   ` 2.6.3-rc1-mm1 Stian Jordet
2004-02-09 10:24   ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-09 10:24     ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-09 10:29     ` 2.6.3-rc1-mm1 Stian Jordet
2004-02-09 10:29       ` 2.6.3-rc1-mm1 Stian Jordet
2004-02-09 11:56     ` 2.6.3-rc1-mm1 Karsten Keil
2004-02-09 11:56       ` 2.6.3-rc1-mm1 Karsten Keil
2004-02-09 19:22       ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-09 19:22         ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-10  2:25         ` 2.6.3-rc1-mm1 Karsten Keil
2004-02-10  2:25           ` 2.6.3-rc1-mm1 Karsten Keil
     [not found]           ` <20040210022343.4ebbc186.akpm@osdl.org>
2004-02-10 17:59             ` 2.6.3-rc1-mm1 Karsten Keil
2004-02-10  1:59     ` 2.6.3-rc1-mm1 bill davidsen
2004-02-09 14:18 ` 2.6.3-rc1-mm1 Philippe Gramoullé
2004-02-09 14:18   ` 2.6.3-rc1-mm1 Philippe Gramoullé
2004-02-09 23:58   ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-09 23:58     ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-10  0:05     ` 2.6.3-rc1-mm1 Philippe Gramoullé
2004-02-10  0:05       ` 2.6.3-rc1-mm1 Philippe Gramoullé
2004-02-11 23:53     ` 2.6.3-rc1-mm1 Philippe Gramoullé
2004-02-11 23:53       ` 2.6.3-rc1-mm1 Philippe Gramoullé
2004-02-09 14:26 ` 2.6.3-rc1-mm1 Philippe Gramoullé
2004-02-09 16:44 ` 2.6.3-rc1-mm1 Dominik Kubla
2004-02-09 16:44   ` 2.6.3-rc1-mm1 Dominik Kubla
2004-02-09 17:42   ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-09 17:42     ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-09 16:54 ` 2.6.3-rc1-mm1 James Morris
2004-02-09 16:54   ` 2.6.3-rc1-mm1 James Morris
2004-02-09 20:02 ` 2.6.3-rc1-mm1 Karl Vogel
2004-02-10 19:45 ` 2.6.3-rc1-mm1 Brian Jackson
2004-02-10 19:45   ` 2.6.3-rc1-mm1 Brian Jackson
2004-02-10 21:05   ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-10 21:05     ` 2.6.3-rc1-mm1 Andrew Morton
2004-02-10 23:51 ` 2.6.3-rc1-mm1 (SELinux + ext3 + nfsd oops) Chris PeBenito
2004-02-11  2:29   ` James Morris
2004-02-11  2:29     ` James Morris
2004-02-11  3:45     ` Chris PeBenito
2004-02-11  5:03       ` James Morris
2004-02-11  5:03         ` James Morris
2004-02-11 17:08 ` 2.6.3-rc1-mm1 Mark Haverkamp
2004-02-14  2:04 ` Eugene Teo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040214020449.GA2252@eugeneteo.net \
    --to=eugene.teo@eugeneteo.net \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.