From: Dave Jones <davej@redhat.com>
To: Olaf Hering <olh@suse.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org
Subject: Re: kernel-smp on i386, too many arguments to function `aty128_find_mem_vbios'
Date: Mon, 16 Feb 2004 16:17:00 +0000 [thread overview]
Message-ID: <20040216161700.GA27470@redhat.com> (raw)
In-Reply-To: <20040216092350.GA23211@suse.de>
On Mon, Feb 16, 2004 at 10:23:50AM +0100, Olaf Hering wrote:
>
> CC [M] drivers/video/aty/radeon_base.o
> drivers/video/aty/radeon_base.c: In function `radeon_screen_blank':
> drivers/video/aty/radeon_base.c:945: warning: `val2' might be used uninitialized in this function
> drivers/video/aty/radeon_base.c: In function `radeonfb_setcolreg':
> drivers/video/aty/radeon_base.c:1026: warning: `vclk_cntl' might be used uninitialized in this function
> drivers/video/aty/radeon_base.c: In function `radeonfb_set_par':
> drivers/video/aty/radeon_base.c:1320: warning: `pll_output_freq' might be used uninitialized in this function
> CC [M] drivers/video/aty/radeon_pm.o
> CC [M] drivers/video/aty/radeon_monitor.o
> drivers/video/aty/radeon_monitor.c: In function `radeon_match_mode':
> drivers/video/aty/radeon_monitor.c:865: warning: passing arg 1 of `fb_validate_mode' discards qualifiers from pointer target type
> CC [M] drivers/video/aty/radeon_accel.o
> CC [M] drivers/video/aty/radeon_i2c.o
> LD [M] drivers/video/aty/atyfb.o
> CC [M] drivers/video/aty/aty128fb.o
> drivers/video/aty/aty128fb.c: In function `aty128_probe':
> drivers/video/aty/aty128fb.c:1955: error: too many arguments to function `aty128_find_mem_vbios'
> make[3]: *** [drivers/video/aty/aty128fb.o] Error 1
> make[2]: *** [drivers/video/aty] Error 2
> make[1]: *** [drivers/video] Error 2
> make: *** [drivers] Error 2
Looks straightforward enough...
Dave
--- linux-2.6.2/drivers/video/aty/aty128fb.c~ 2004-02-16 14:39:19.000000000 +0000
+++ linux-2.6.2/drivers/video/aty/aty128fb.c 2004-02-16 14:40:25.000000000 +0000
@@ -1952,7 +1952,7 @@
bios = aty128_map_ROM(par, pdev);
#ifdef __i386__
if (bios == NULL)
- bios = aty128_find_mem_vbios(par, pdev);
+ bios = aty128_find_mem_vbios(par);
#endif
if (bios == NULL)
printk(KERN_INFO "aty128fb: BIOS not located, guessing timings.\n");
next prev parent reply other threads:[~2004-02-16 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 9:23 kernel-smp on i386, too many arguments to function `aty128_find_mem_vbios' Olaf Hering
2004-02-16 16:17 ` Dave Jones [this message]
2004-02-16 21:51 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040216161700.GA27470@redhat.com \
--to=davej@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.