From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: Peter Nelson <pnelson@andrew.cmu.edu>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] PSX support in input/joystick/gamecon.c
Date: Tue, 17 Feb 2004 01:08:06 -0500 [thread overview]
Message-ID: <200402170108.07271.dtor_core@ameritech.net> (raw)
In-Reply-To: <4031AB8D.1040209@andrew.cmu.edu>
On Tuesday 17 February 2004 12:50 am, Peter Nelson wrote:
> +module_param_array(gc, int, gc_count, 0);
> +module_param_array(gc_2, int, gc_2_count, 0);
> +module_param_array(gc_3, int, gc_3_count, 0);
> +module_param(gc_psx_delay, int, 0);
> +module_param(gc_psx_ddr, int, 0);
Nitpick: module_param, if module is compiled in, adds a prefix to parameter
names, so the parameters will be:
gamecon.gc
gamecon.gc_2
gamecon.gc_3
gamecon.gc_psx_delay
gamecon.gc_psx_ddr
At least with PSX stuff it would be nice to drop gc_ prefix.
--
Dmitry
next prev parent reply other threads:[~2004-02-17 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040215222107.720832C2CC@lists.samba.org>
2004-02-17 5:50 ` [PATCH] PSX support in input/joystick/gamecon.c Peter Nelson
2004-02-17 6:08 ` Dmitry Torokhov [this message]
2004-02-17 6:57 ` Peter Nelson
2004-02-17 7:39 ` Peter Nelson
2004-02-17 13:03 ` Stefan Smietanowski
2004-02-07 10:08 iuri.f
-- strict thread matches above, loose matches on Subject: below --
2004-02-06 18:48 iuri.f
2004-02-06 23:17 ` [PATCH] " Peter Nelson
2004-02-06 18:06 Peter Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402170108.07271.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pnelson@andrew.cmu.edu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.