All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <syrjala@sci.fi>
To: alsa-devel@lists.sourceforge.net
Subject: [PATCH] Maestro2 hw volume fix
Date: Tue, 17 Feb 2004 08:20:41 +0200	[thread overview]
Message-ID: <20040217062041.GA6708@sci.fi> (raw)

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

The attached patch fixes hardware volume buttons on my Dell Inspiron 7000 
laptop. The chip is ESS Maestro2 (0x125d:0x1968).

I have no idea if this will break things for someone else. Since the 
datasheet didn't help me understand the registers involved I just printed 
their contents and came up with the used bits.

All registers had the following values in my tests:
mute:     0x99
vol down: 0x77
vol up:   0xBB

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/

[-- Attachment #2: maestro_hwvol.patch --]
[-- Type: text/plain, Size: 617 bytes --]

--- alsa-driver-0.9.8/alsa-kernel/pci/es1968.c.orig	2003-10-14 16:59:20.000000000 +0300
+++ alsa-driver-0.9.8/alsa-kernel/pci/es1968.c	2004-02-17 08:06:22.000000000 +0200
@@ -1967,14 +1967,14 @@
 
 	/* FIXME: more clean up is needed.. */
 	val = chip->ac97->regs[AC97_MASTER];
-	if (x & 1) {
+	if (!(x & 2)) {
 		/* mute */
 		snd_ac97_write_cache(chip->ac97, AC97_MASTER, val ^ 0x8000);
 		snd_ctl_notify(chip->card, SNDRV_CTL_EVENT_MASK_VALUE,
 			       &chip->master_switch->id);
 	} else {
 		val &= 0x7fff;
-		if (((x>>1) & 7) > 4) {
+		if (!(x & 4)) {
 			/* volume up */
 			if ((val & 0xff) > 0)
 				val--;

             reply	other threads:[~2004-02-17  6:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-17  6:20 Ville Syrjälä [this message]
2004-02-17 15:38 ` [PATCH] Maestro2 hw volume fix Takashi Iwai
2004-02-17 16:51   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040217062041.GA6708@sci.fi \
    --to=syrjala@sci.fi \
    --cc=alsa-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.