Re: EISA & sysfs.

[Dave Jones <davej@redhat.com>]

On Wed, Feb 18, 2004 at 04:24:15PM +0100, Marc Zyngier wrote:

 > EISA-ID table terminator. What about changing it to :
 > 
 > static struct eisa_device_id hp100_eisa_tbl[] = {
 >         { "HWPF180" }, /* HP J2577 rev A */
 >         { "HWP1920" }, /* HP 27248B */
 >         { "HWP1940" }, /* HP J2577 */
 >         { "HWP1990" }, /* HP J2577 */
 >         { "CPX0301" }, /* ReadyLink ENET100-VG4 */
 >         { "CPX0401" }, /* FreedomLine 100/VG */
 >         { "" },        /* THIS ENTRY IS MANDATORY !!! */
 > };

ok, that stops it hanging at least, it now barfs a little failure
message, and a calltrace.  This seems awfully verbose for a failure
path that isn't unreasonable IMO.

kernel: kobject_register failed for hp100 (-17)
kernel: Call Trace:
kernel:  [<c01d3662>] kobject_register+0x31/0x39
kernel:  [<c0221d0c>] bus_add_driver+0x2e/0x83
kernel:  [<c01db6db>] pci_register_driver+0x6b/0x87
kernel:  [<c78078ad>] hp100_module_init+0x12/0x22 [hp100]
kernel:  [<c013c0fc>] sys_init_module+0x14e/0x25e
kernel:  [<c010b697>] syscall_call+0x7/0xb


Something also seems awry someplace else..

(15:54:51:root@mindphaser:linux-2.6.2)# cat /proc/modules  | grep hp100
(15:54:55:root@mindphaser:linux-2.6.2)# rmmod hp100
ERROR: Module hp100 does not exist in /proc/modules
(15:55:18:root@mindphaser:linux-2.6.2)# modprobe hp100
FATAL: Module hp100 already in kernel.
(15:55:25:root@mindphaser:linux-2.6.2)# cat /proc/modules | grep hp100
(15:55:33:root@mindphaser:linux-2.6.2)#

Odd.

	Dave