All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: tony@atomide.com, linux-kernel@vger.kernel.org
Subject: Re: Intel x86-64 support patch breaks amd64
Date: Fri, 20 Feb 2004 17:44:54 +0100	[thread overview]
Message-ID: <20040220174454.77ec7086.ak@suse.de> (raw)
In-Reply-To: <20040219193606.GC31589@devserv.devel.redhat.com>

On Thu, 19 Feb 2004 14:36:10 -0500
Jakub Jelinek <jakub@redhat.com> wrote:

> On Fri, Feb 20, 2004 at 05:13:37PM +0100, Andi Kleen wrote:
> > --- linux-2.6.3/arch/x86_64/kernel/x8664_ksyms.c-o	2004-02-19 09:01:09.000000000 +0100
> > +++ linux-2.6.3/arch/x86_64/kernel/x8664_ksyms.c	2004-02-19 09:08:04.000000000 +0100
> > @@ -194,7 +194,9 @@
> >  
> >  EXPORT_SYMBOL(die_chain);
> >  
> > +#ifdef CONFIG_SMP_
> 
> 		    ^ Isn't this a typo?

Indeed. Thanks for catching it.

It probably doesn't hurt because I don't know of any module that uses cpu_sibling_map[].
I think I just copied the export from i386. Maybe it would be best to just remove it completely.

-Andi

  reply	other threads:[~2004-02-19 19:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-19 18:34 Intel x86-64 support patch breaks amd64 Tony Lindgren
2004-02-20 16:13 ` Andi Kleen
2004-02-19 19:36   ` Jakub Jelinek
2004-02-20 16:44     ` Andi Kleen [this message]
2004-02-19 21:20       ` Philippe Elie
2004-02-20 19:32         ` [PATCH] Fix typo in x86-64 fix Andi Kleen
2004-02-19 20:39   ` Intel x86-64 support patch breaks amd64 Tony Lindgren
2004-02-20 19:02     ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2004-02-19 20:45 Siddha, Suresh B
2004-02-20 19:29 ` Andi Kleen
2004-02-19 21:14   ` Tony Lindgren
2004-02-19 21:14 Siddha, Suresh B
2004-02-20 20:12 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040220174454.77ec7086.ak@suse.de \
    --to=ak@suse.de \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.