From: Arnd Bergmann <arnd@arndb.de>
To: Mike Strosaker <strosake@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch-specific callout in panic()
Date: Mon, 23 Feb 2004 10:25:05 +0100 [thread overview]
Message-ID: <200402231025.05630.arnd@arndb.de> (raw)
Mike Strosaker <strosake@austin.ibm.com> wrote:
>@@ -53,7 +53,8 @@
> static char buf[1024];
> va_list args;
> #if defined(CONFIG_ARCH_S390)
>- unsigned long caller = (unsigned long) __builtin_return_address(0);
>+ extern unsigned long panic_caller;
>+ panic_caller = (unsigned long) __builtin_return_address(0);
> #endif
>
> bust_spinlocks(1);
...
>+ machine_panic();
>+
Why don't you just pass __builtin_return_address(0) to machine_panic for
everyone? It will get you rid of the #ifdef completely and the argument
can still be ignored.
Also, arch_panic() might be a little clearer than machine_panic().
Arnd <><
next reply other threads:[~2004-02-23 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 9:25 Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-02-23 5:13 [PATCH] arch-specific callout in panic() Mike Strosaker
2004-02-23 5:34 ` Andrew Morton
2004-02-23 18:33 ` Mike Strosaker
2004-02-24 4:25 ` Keith Owens
2004-02-23 5:54 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402231025.05630.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=strosake@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.