From: "David S. Miller" <davem@redhat.com>
To: Michal Ludvig <mludvig@suse.cz>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] XFRM policy expire
Date: Wed, 25 Feb 2004 00:18:09 -0800 [thread overview]
Message-ID: <20040225001809.7d27dd8d.davem@redhat.com> (raw)
In-Reply-To: <403B14DA.3000700@suse.cz>
On Tue, 24 Feb 2004 10:09:46 +0100
Michal Ludvig <mludvig@suse.cz> wrote:
> the attached patch fixes a bug in xfrm_send_policy_notify(). The space
> allocated in skb must include 'sizeof(struct xfrm_user_polexpire)', not
> 'sizeof(struct xfrm_userpolicy_info)' which is shorter. On ia32 it
> worked, probably because of some space gained from aligning.
> Unfortunately on amd64 it didn't and finally led to BUG() & kernel hangup.
Applied, thanks Michal.
> BTW The second patch attached does some obvious cleanup: replaces
> RTA_ALIGN(RTA_LENGTH(x)) with RTA_SPACE(x) and ditto for NLMSG_*()
> macros. Apply on top of the first one or drop it. It's up to you.
This is fine too, also applied.
Thanks again.
prev parent reply other threads:[~2004-02-25 8:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 9:09 [PATCH] XFRM policy expire Michal Ludvig
2004-02-25 8:18 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040225001809.7d27dd8d.davem@redhat.com \
--to=davem@redhat.com \
--cc=mludvig@suse.cz \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.