From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: yoshfuji@linux-ipv6.org, ak@muc.de, netdev@oss.sgi.com,
mostrows@styx.uwaterloo.ca
Subject: Re: [PATCH] Increase snd/rcv buffers in pppoe
Date: Mon, 23 Feb 2004 20:12:01 +0000 (UTC)
Date: Wed, 25 Feb 2004 21:15:26 +0100 [thread overview]
Message-ID: <20040225211526.74478066.ak@suse.de> (raw)
In-Reply-To: <20040223102613.33838132.davem@redhat.com>
On Mon, 23 Feb 2004 10:26:13 -0800
"David S. Miller" <davem@redhat.com> wrote:
>
> The proposal I make intends to avoid this endless tweaking.
[...] Sounds good to me.
> Two more observations while grepping for SK_{R,W}MEM_MAX.
>
> 1) IPV4 icmp sents sk_sndbuf of it's sockets to "2 * SK_WMEM_MAX", that's not
> what it really wants. What it really wants is enough space to hold
> ~2 full sized IPV4 packets, roughly 2 * 64K + struct sk_buff overhead
> and thus that is what it should be using there.
Just sk_buff overhead for what MTU? 576? (would be a bit extreme)
And in theory it could be one byte packets too.
> 2) IPV6 icmp does the same as ipv4, except this value is even more wrong there
> especially considering jumbograms. With current code, sending a jumbogram
> ipv6 icmp packet would simply fail, and I wonder if anyone has even tried
> this.
Isn't even ICMPv6 limited to the minimum guaranteed MTU (1000 something) like ICMPv4 is to
576 bytes?
-Andi
next prev parent reply other threads:[~2004-02-23 20:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-22 23:47 [PATCH] Increase snd/rcv buffers in pppoe Andi Kleen
2004-02-23 7:26 ` David S. Miller
2004-02-23 10:53 ` Andi Kleen
2004-02-23 11:01 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-23 11:16 ` Andi Kleen
2004-02-23 11:38 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-23 18:26 ` David S. Miller
2004-02-23 20:12 ` Andi Kleen [this message]
2004-02-23 21:32 ` David S. Miller
2004-02-26 19:49 ` Andi Kleen
2004-02-26 20:42 ` David S. Miller
2004-02-26 20:52 ` Andi Kleen
2004-02-26 22:03 ` Andi Kleen
2004-02-26 22:22 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040225211526.74478066.ak@suse.de \
--to=ak@suse.de \
--cc=ak@muc.de \
--cc=davem@redhat.com \
--cc=mostrows@styx.uwaterloo.ca \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.