From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Mansfield Date: Wed, 03 Mar 2004 22:43:34 +0000 Subject: [PATCH] fix NAME="foo-%c{N}" gets a truncated name Message-Id: <20040303144334.A20521@beaverton.ibm.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Here is a fix and a new test for the problem Atul hit, where if we have a NAME based on a result of the form: NAME="foo-%c{7}" udev truncates the name. Without any prefix (the foo- in this example), the rule was working OK. === namedev.c 1.122 vs edited ==--- 1.122/namedev.c Tue Mar 2 21:00:21 2004 +++ edited/namedev.c Wed Mar 3 14:16:54 2004 @@ -285,7 +285,7 @@ dbg("requested part of result string not found"); break; } - strnfieldcat(string, udev->program_result + spos, slen+1); + strnfieldcat(string, udev->program_result + spos, maxsize); dbg("substitute part of result string '%s'", pos); } else { strnfieldcat(string, udev->program_result, maxsize); === test/udev-test.pl 1.40 vs edited ==--- 1.40/test/udev-test.pl Fri Feb 27 19:36:01 2004 +++ edited/test/udev-test.pl Wed Mar 3 14:20:05 2004 @@ -262,6 +262,15 @@ EOF }, { + desc => "lots of arguments and characters before %c{N}", + subsys => "block", + devpath => "block/sda/sda3", + expected => "my-foo9" , + conf => < "program result substitution (numbered part of)", subsys => "block", devpath => "block/sda/sda3", ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel