From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "debian-powerpc@lists.debian.org"
<debian-powerpc@lists.debian.org>,
"Linux Kernel list" <linux-kernel@vger.kernel.org>,
"Matthias Urlichs" <smurf@smurf.noris.de>,
"Martin-Éric Racine" <q-funk@pp.fishpool.fi>
Subject: Re: [PATCH] For test only: pmac_zilog fixes (cups lockup at boot):
Date: Fri, 5 Mar 2004 09:24:22 +0000 [thread overview]
Message-ID: <20040305092422.C22156@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1078477504.5700.69.camel@gaston>; from benh@kernel.crashing.org on Fri, Mar 05, 2004 at 08:05:05PM +1100
On Fri, Mar 05, 2004 at 08:05:05PM +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2004-03-05 at 19:58, Russell King wrote:
> > On Fri, Mar 05, 2004 at 06:54:31PM +1100, Benjamin Herrenschmidt wrote:
> > > Ok, so I finally got a hand on the problems. A mix of bugs in
> > > the driver, bugs in the HW, and bugs in the TTY layer ! pfiew.
> >
> > I'm not even going to bother reviewing these changes - the gratuitous
> > change of "up" to "uap" makes this task virtually impossible.
>
> Oh... and the change wasn't gratuitous... "up" do actually conflict
> with up() as soon as you try to use a semaphore :)
Yes, I know - but the point is its impossible to review, and I think
you at least have an extra level of locking which isn't needed.
But I wouldn't know because of the huge number of changes which make
it impossible to read.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-03-05 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-05 7:54 [PATCH] For test only: pmac_zilog fixes (cups lockup at boot): Benjamin Herrenschmidt
2004-03-05 8:58 ` Russell King
2004-03-05 9:02 ` Benjamin Herrenschmidt
2004-03-05 9:18 ` serial driver / tty issues Benjamin Herrenschmidt
2004-03-05 9:41 ` Russell King
2004-03-05 11:13 ` Benjamin Herrenschmidt
2004-03-05 9:05 ` [PATCH] For test only: pmac_zilog fixes (cups lockup at boot): Benjamin Herrenschmidt
2004-03-05 9:24 ` Russell King [this message]
2004-03-05 9:29 ` Benjamin Herrenschmidt
2004-03-05 9:48 ` Russell King
2004-03-05 11:14 ` Benjamin Herrenschmidt
2004-03-05 17:52 ` Matthias Urlichs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040305092422.C22156@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=benh@kernel.crashing.org \
--cc=debian-powerpc@lists.debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=q-funk@pp.fishpool.fi \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.