From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] Input patches: synaptics passthrough fix
Date: Thu, 11 Mar 2004 02:30:59 -0500 [thread overview]
Message-ID: <200403110231.01676.dtor_core@ameritech.net> (raw)
In-Reply-To: <200403110230.07892.dtor_core@ameritech.net>
===================================================================
ChangeSet@1.1663, 2004-03-11 01:43:39-05:00, dtor_core@ameritech.net
Input: do a full reset of Synaptics touchpad if extended protocol
probes failed, otherwise trackpoint on the pass-through port
may stop working (reset-disable isn't enough to revive it)
psmouse-base.c | 23 +++++++++++++++++++++--
psmouse.h | 1 +
synaptics.c | 13 +------------
3 files changed, 23 insertions(+), 14 deletions(-)
===================================================================
diff -Nru a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
--- a/drivers/input/mouse/psmouse-base.c Thu Mar 11 02:07:38 2004
+++ b/drivers/input/mouse/psmouse-base.c Thu Mar 11 02:07:38 2004
@@ -287,6 +287,24 @@
return 0;
}
+
+/*
+ * psmouse_reset() resets the mouse into power-on state.
+ */
+int psmouse_reset(struct psmouse *psmouse)
+{
+ unsigned char param[2];
+
+ if (psmouse_command(psmouse, param, PSMOUSE_CMD_RESET_BAT))
+ return -1;
+
+ if (param[0] != PSMOUSE_RET_BAT && param[1] != PSMOUSE_RET_ID)
+ return -1;
+
+ return 0;
+}
+
+
/*
* Genius NetMouse magic init.
*/
@@ -416,6 +434,7 @@
* pass through port it could get disabled while probing for protocol
* extensions.
*/
+ psmouse_reset(psmouse);
psmouse_command(psmouse, NULL, PSMOUSE_CMD_RESET_DIS);
}
@@ -540,8 +559,8 @@
static void psmouse_cleanup(struct serio *serio)
{
struct psmouse *psmouse = serio->private;
- unsigned char param[2];
- psmouse_command(psmouse, param, PSMOUSE_CMD_RESET_BAT);
+
+ psmouse_reset(psmouse);
}
/*
diff -Nru a/drivers/input/mouse/psmouse.h b/drivers/input/mouse/psmouse.h
--- a/drivers/input/mouse/psmouse.h Thu Mar 11 02:07:38 2004
+++ b/drivers/input/mouse/psmouse.h Thu Mar 11 02:07:38 2004
@@ -65,6 +65,7 @@
#define PSMOUSE_SYNAPTICS 7
int psmouse_command(struct psmouse *psmouse, unsigned char *param, int command);
+int psmouse_reset(struct psmouse *psmouse);
extern int psmouse_smartscroll;
extern unsigned int psmouse_rate;
diff -Nru a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
--- a/drivers/input/mouse/synaptics.c Thu Mar 11 02:07:38 2004
+++ b/drivers/input/mouse/synaptics.c Thu Mar 11 02:07:38 2004
@@ -92,17 +92,6 @@
return 0;
}
-static int synaptics_reset(struct psmouse *psmouse)
-{
- unsigned char r[2];
-
- if (psmouse_command(psmouse, r, PSMOUSE_CMD_RESET_BAT))
- return -1;
- if (r[0] == PSMOUSE_RET_BAT && r[1] == PSMOUSE_RET_ID)
- return 0;
- return -1;
-}
-
/*
* Read the model-id bytes from the touchpad
* see also SYN_MODEL_* macros
@@ -197,7 +186,7 @@
{
int retries = 0;
- while ((retries++ < 3) && synaptics_reset(psmouse))
+ while ((retries++ < 3) && psmouse_reset(psmouse))
printk(KERN_ERR "synaptics reset failed\n");
if (synaptics_identify(psmouse))
next prev parent reply other threads:[~2004-03-11 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-11 7:26 [PATCH 0/3] Input patches Dmitry Torokhov
2004-03-11 7:30 ` [PATCH 1/3] Input patches: psmouse cleanup fix Dmitry Torokhov
2004-03-11 7:30 ` Dmitry Torokhov [this message]
2004-03-11 7:31 ` [PATCH 3/3] Input patches: synaptics restore taps Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403110231.01676.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.