All of lore.kernel.org
 help / color / mirror / Atom feed
* PATCH [3/15] qla2xxx:  Increase MBX IOXB timeout
@ 2004-03-14  8:24 Andrew Vasquez
  0 siblings, 0 replies; only message in thread
From: Andrew Vasquez @ 2004-03-14  8:24 UTC (permalink / raw)
  To: James Bottomley; +Cc: SCSI Mailing List

ChangeSet
  1.1659 04/02/28 21:50:11 andrew.vasquez@qlogic.com +1 -0
  Fix a problem where during heavy I/O the driver would
  improperly timeout an outstanding MBX IOCB before the
  firmware itself had a chance to issue and wait for the
  command to timeout.

  drivers/scsi/qla2xxx/qla_rscn.c
    1.3 04/02/28 21:50:05 andrew.vasquez@qlogic.com +5 -3
    Wait at most 4 * R_A_TOV before timing-out an MBX IOCB.

 drivers/scsi/qla2xxx/qla_rscn.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

ftp://ftp.qlogic.com/outgoing/linux/patches/8.x/8.00.00b11k/12_mbx_iocb_timeout.patch

diff -Nru a/drivers/scsi/qla2xxx/qla_rscn.c b/drivers/scsi/qla2xxx/qla_rscn.c
--- a/drivers/scsi/qla2xxx/qla_rscn.c	Fri Mar 12 17:06:46 2004
+++ b/drivers/scsi/qla2xxx/qla_rscn.c	Fri Mar 12 17:06:46 2004
@@ -292,15 +292,17 @@
  *
  * NOTE:
  * The firmware shall timeout an outstanding mailbox IOCB in 2 * R_A_TOV (in
- * tenths of a second).  The driver will wait 2.5 * R_A_TOV before scheduling
- * a recovery (big hammer).
+ * tenths of a second) after it hits the wire.  But, if there are any request
+ * resource contraints (i.e. during heavy I/O), exchanges can be held off for
+ * at most R_A_TOV.  Therefore, the driver will wait 4 * R_A_TOV before
+ * scheduling a recovery (big hammer).
  */
 static inline void
 qla2x00_add_iodesc_timer(struct io_descriptor *iodesc)
 {
 	unsigned long timeout;
 
-	timeout = ((iodesc->ha->r_a_tov * 2) + (iodesc->ha->r_a_tov / 2)) / 10;
+	timeout = (iodesc->ha->r_a_tov * 4) / 10;
 	init_timer(&iodesc->timer);
 	iodesc->timer.data = (unsigned long) iodesc;
 	iodesc->timer.expires = jiffies + (timeout * HZ);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-03-14  8:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-14  8:24 PATCH [3/15] qla2xxx: Increase MBX IOXB timeout Andrew Vasquez

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.