From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B2ZOV-0005v9-2x
	for mharc-grub-devel@gnu.org; Sun, 14 Mar 2004 12:27:23 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B2ZOS-0005tS-AY
	for grub-devel@gnu.org; Sun, 14 Mar 2004 12:27:20 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B2ZNp-0005eS-IG
	for grub-devel@gnu.org; Sun, 14 Mar 2004 12:27:12 -0500
Received: from [213.228.0.62] (helo=postfix4-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B2ZNp-0005eI-50
	for grub-devel@gnu.org; Sun, 14 Mar 2004 12:26:41 -0500
Received: from openbrick.enbug.org (boitelle-1-82-66-127-114.fbx.proxad.net
	[82.66.127.114])
	by postfix4-1.free.fr (Postfix) with ESMTP id 75364D6775
	for <grub-devel@gnu.org>; Sun, 14 Mar 2004 18:26:36 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by openbrick.enbug.org (Postfix) with ESMTP id C16CC177500
	for <grub-devel@gnu.org>; Sun, 14 Mar 2004 20:26:47 +0100 (CET)
From: "Yoshinori K. Okuji" <okuji@enbug.org>
Organization: enbug.org
To: The development of GRUB 2 <grub-devel@gnu.org>
Date: Sun, 14 Mar 2004 18:29:32 +0100
User-Agent: KMail/1.5.3
References: <20040314115054.GA16146@dekkers.cx>
In-Reply-To: <20040314115054.GA16146@dekkers.cx>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200403141829.32769.okuji@enbug.org>
Subject: Re: Small cleanup patch
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Mar 2004 17:27:21 -0000

On Sunday 14 March 2004 12:50, Jeroen Dekkers wrote:
>       * fs/fat.c (log2): Change name to grub_log2. All callers 
changed.

This should be written like this:

        * fs/fat.c (log2): Renamed to ...
        (grub_log2): ... this.
        All callers changed.

This is the traditional in GRUB.

BTW, I think this function should be named fat_log2 rather than
grub_log2, because it's local. Or, is it better to define this globally
in somewhere else?

The other changes are very good.

Thanks,
Okuji