From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B2nmr-0005ml-NW
	for qemu-devel@nongnu.org; Mon, 15 Mar 2004 03:49:29 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B2nmC-0005fk-Sq
	for qemu-devel@nongnu.org; Mon, 15 Mar 2004 03:49:21 -0500
Received: from [130.136.10.114] (helo=pob.cs.unibo.it)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B2nmC-0005fB-HR
	for qemu-devel@nongnu.org; Mon, 15 Mar 2004 03:48:48 -0500
Date: Mon, 15 Mar 2004 09:48:41 +0100
Subject: Re: [Qemu-devel] Progress
Message-ID: <20040315084841.GA10528@cs.unibo.it>
References: <1078345395.2253.6.camel@espiron.av7.local>
	<1078753704.4455.17227.camel@jma1.dev.netgem.com>
	<4054D5E3.8080509@bellard.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4054D5E3.8080509@bellard.org>
From: renzo@cs.unibo.it (Renzo Davoli)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Mar 14, 2004 at 11:00:03PM +0100, Fabrice Bellard wrote:
> - multiple network interface support (untested)

I have found a minor bug about this:
the management of the -tun-fd option (changed to cope with multiple
interfaces) is buggy, it is a for(;;) loop with no exiting break.

The fix is very simple:
*** vl.c.orig   Mon Mar 15 09:43:50 2004
--- vl.c        Mon Mar 15 09:39:15 2004
***************
*** 980,986 ****
                          } else if (*p != '\0') {
                              fprintf(stderr, "qemu: invalid fd for
network interface %d\n", nb_nics);
                              exit(1);
!                         }
                      }
                  }
                break;
--- 980,987 ----
                          } else if (*p != '\0') {
                              fprintf(stderr, "qemu: invalid fd for
network interface %d\n", nb_nics);
                              exit(1);
!                         } else
!                               break;
                      }
                  }
                break;