All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Fasheh <mark.fasheh@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH]2.6 mechanism for holding private inode data
Date: Mon Mar 15 16:16:58 2004	[thread overview]
Message-ID: <20040315221654.GD20057@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20040314223440.GA1408@penguin.co.intel.com>

On Sun, Mar 14, 2004 at 02:34:40PM -0800, Rusty Lynch wrote:
> Here is a patch that stores the inode private data as you talked about above.
> There is a little more complexity because you have to handle the cases where:
> * new inodes are created via ocfs_mknod and ocfs_symlink, and we need to
>   start setting private data before ocfs_populate_inode
> * reading the root inode in ocfs_read_inode2 (2.4 kernel) or
>   ocfs_read_locked_inode (2.6 kernel) where we just directly populate the
>   inode and do not call ocfs_populate_inode()
this is good. I'm going to do some testing on this today, though it looks
pretty sane.

> There is really no difference between a 2.4 and 2.6 build (other then where
> to put the code for reading the root inode.)
Yeah, and the code is so much cleaner now too :)
Just to be sure, this covers all you need in 2.6 to get the inode stuff
going too, correct? For 2.6, it looks like you're using the generic_ip
route, which is fine if you feel that there aren't any major disadvantages
(the only thing I can think of is memory allocation related).
	--Mark

--
Mark Fasheh
Software Developer, Oracle Corp
mark.fasheh@oracle.com

  reply	other threads:[~2004-03-15 16:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-10 22:49 [Ocfs2-devel] [PATCH]2.6 mechanism for holding private inode data Rusty Lynch
2004-03-11 15:53 ` Rusty Lynch
2004-03-12 14:47   ` Mark Fasheh
2004-03-12 15:07     ` Rusty Lynch
2004-03-12 18:09       ` Mark Fasheh
2004-03-13 12:40         ` Rusty Lynch
2004-03-13 12:44           ` Wim Coekaerts
2004-03-14 16:34         ` Rusty Lynch
2004-03-15 16:16           ` Mark Fasheh [this message]
2004-03-15 16:40             ` Rusty Lynch
2004-03-16 18:35             ` Mark Fasheh
  -- strict thread matches above, loose matches on Subject: below --
2004-03-12 17:40 Villalovos, John L
2004-03-15 15:55 ` Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040315221654.GD20057@ca-server1.us.oracle.com \
    --to=mark.fasheh@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.