From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: sjhill@realitydiluted.com, linux-mips@linux-mips.org
Subject: Re: [PATCH] [RFC] r4k_dma_cache_wback_inv function fails when size=0...
Date: Tue, 16 Mar 2004 17:01:14 +0100 [thread overview]
Message-ID: <20040316160114.GA19837@linux-mips.org> (raw)
In-Reply-To: <20040316.230928.74756852.anemo@mba.ocn.ne.jp>
On Tue, Mar 16, 2004 at 11:09:28PM +0900, Atsushi Nemoto wrote:
> sjhill> The 'r4k_dma_cache_wback_inv' function will fail when the
> sjhill> requested size equals 0 AND when the address is a multiple of
> sjhill> the line size. I discovered this bug while using the National
> sjhill> Semiconductor DP8381x series PCI ethernet driver. I have
> sjhill> attached a test program showing the bug as well as a patch for
> sjhill> comment. Okay to apply?
>
> I think your patch is overkill. It flushes many one line then needed.
So far I was simply considering any use with size 0 a bug. In this case
a 0 argument was passed to pci_unmap_XXX, so I'll have to figure out with
the other architecture maintainers if that's just odd usage of the API
or an outright bug.
Ralf
prev parent reply other threads:[~2004-03-16 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 17:08 [PATCH] [RFC] r4k_dma_cache_wback_inv function fails when size=0 Steven J. Hill
2004-03-16 14:09 ` Atsushi Nemoto
2004-03-16 16:01 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316160114.GA19837@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=sjhill@realitydiluted.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.