Re: fsck.reiser4 infinite loop

[Vitaly Fertman <vitaly@namesys.com>]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

On Tuesday 16 March 2004 17:56, Vince wrote:
> Vitaly Fertman wrote:
> > thank you for hitting this, I have attached the updated patch for
> > reiser4progs. it should cure for the problem, email me about your results
> > please.
>
> It looks that I'm quite good at hitting bugs ;-)

good day.

> Ok, yet another problem: fsck.reiser4 on my other reiser4 partition
> loops on some entry. I can pack the metadata and make it available if
> needed, for now here is the log:

I see the problem, although not sure that the attached patch will 
fix it correctly. If it does not, I need to have a look at the metadata.

p.s. waiting for other bug reports :)

-- 
Thanks,
Vitaly Fertman

[-- Attachment #2: dir40_check.patch --]
[-- Type: text/x-diff, Size: 466 bytes --]

===== plugin/object/dir40/dir40_repair.c 1.88 vs edited =====
--- 1.88/plugin/object/dir40/dir40_repair.c	Thu Mar 11 22:01:47 2004
+++ edited/plugin/object/dir40/dir40_repair.c	Tue Mar 16 18:07:00 2004
@@ -316,6 +316,10 @@
 
 
 			if (mode != RM_BUILD) {
+				/* If not the BUILD mode, continue with the 
+				   entry key, not the correct one. */
+				plug_call(key.plug->o.key_ops, assign,
+					  &key, &entry.offset);
 				res |= RE_FATAL;
 				goto next;
 			}