From: Matt Mackall <mpm@selenic.com>
To: Meelis Roos <mroos@linux.ee>
Cc: netdev@oss.sgi.com, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: netpoll warning in tulip
Date: Tue, 16 Mar 2004 13:23:48 -0600 [thread overview]
Message-ID: <20040316192347.GC11010@waste.org> (raw)
In-Reply-To: <Pine.GSO.4.44.0403161235170.29946-100000@math.ut.ee>
On Tue, Mar 16, 2004 at 12:36:02PM +0200, Meelis Roos wrote:
> FYI: with netpoll configured out, I get
>
> CC [M] drivers/net/tulip/tulip_core.o
> drivers/net/tulip/tulip_core.c:256: warning: `poll_tulip' declared `static' but never defined
2.6.5-rc1-mpm/drivers/net/tulip/tulip_core.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/net/tulip/tulip_core.c~tulip-poll drivers/net/tulip/tulip_core.c
--- 2.6.5-rc1/drivers/net/tulip/tulip_core.c~tulip-poll 2004-03-16 13:21:38.000000000 -0600
+++ 2.6.5-rc1-mpm/drivers/net/tulip/tulip_core.c 2004-03-16 13:22:30.000000000 -0600
@@ -253,8 +253,9 @@ static void tulip_down(struct net_device
static struct net_device_stats *tulip_get_stats(struct net_device *dev);
static int private_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);
static void set_rx_mode(struct net_device *dev);
+#ifdef CONFIG_NET_POLL_CONTROLLER
static void poll_tulip(struct net_device *dev);
-
+#endif
static void tulip_set_power_state (struct tulip_private *tp,
int sleep, int snooze)
_
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
next prev parent reply other threads:[~2004-03-16 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-16 10:36 netpoll warning in tulip Meelis Roos
2004-03-16 19:23 ` Matt Mackall [this message]
2004-03-16 20:37 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316192347.GC11010@waste.org \
--to=mpm@selenic.com \
--cc=jgarzik@pobox.com \
--cc=mroos@linux.ee \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.