All of lore.kernel.org
 help / color / mirror / Atom feed
From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] Patch to change char * into char[]
Date: Tue, 16 Mar 2004 19:23:54 +0000	[thread overview]
Message-ID: <200403162023.54785.domen@coderock.org> (raw)
In-Reply-To: <1079109894.756.34.camel@chopin.internal.nit.ca>

On Tuesday 16 of March 2004 09:25, maximilian attems wrote:
> hello peter,
> 
> On Fri, 12 Mar 2004, Peter McCurdy wrote:
> > diff -ruN linux-2.6.4-kj-orig/drivers/net/irda/ali-ircc.c linux-2.6.4/drivers/net/irda/ali-ircc.c
> > --- linux-2.6.4-kj-orig/drivers/net/irda/ali-ircc.c	Fri Mar 12 10:15:01 2004
> > +++ linux-2.6.4/drivers/net/irda/ali-ircc.c	Fri Mar 12 10:47:24 2004
> > @@ -49,7 +49,7 @@
> >  #define CHIP_IO_EXTENT 8
> >  #define BROKEN_DONGLE_ID
> >  
> > -static char *driver_name = "ali-ircc";
> > +static char driver_name[] = "ali-ircc";
> >  
> >  /* Module parameters */
> >  static int qos_mtt_bits = 0x07;  /* 1 ms or more */
> 
> first line size(1) output is before your patch, 2 line after.
> 
>    text    data     bss     dec     hex filename
>   17575     784      48   18407    47e7 ali-ircc.o
>   17582     784      48   18414    47ee ali-ircc.o
> 
> didn't help.

   text    data     bss     dec     hex filename
  11669     152      48   11869    2e5d drivers/net/irda/ali-ircc.o # char *driver_name
  11660     152      48   11860    2e54 drivers/net/irda/ali-ircc.o # char driver_name[]
  11669     152      48   11869    2e5d drivers/net/irda/ali-ircc.o # const char driver_name[]

Did help! :-) (gcc version 3.3.3, compiled with make drivers/net/irda/ali-ircc.o)
If you want, i can check others too.

Any idea why const version is longer?


	Domen
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-03-16 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-12 16:44 [Kernel-janitors] Patch to change char * into char[] Peter McCurdy
2004-03-16  8:25 ` maximilian attems
2004-03-16 19:23 ` Domen Puncer [this message]
2004-03-16 20:18 ` maximilian attems
2004-03-17  1:24 ` Domen Puncer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200403162023.54785.domen@coderock.org \
    --to=domen@coderock.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.