From: Tom Rini <trini@kernel.crashing.org>
To: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: fix ppc compile
Date: Tue, 16 Mar 2004 14:20:11 -0700 [thread overview]
Message-ID: <20040316212011.GA20967@smtp.west.cox.net> (raw)
In-Reply-To: <20040316210540.GD24623@redhat.com>
On Tue, Mar 16, 2004 at 09:05:40PM +0000, Dave Jones wrote:
> 2.6.5rc1 changes this function, but there is no 'dev' argument there.
> This makes it look a little more sane, but I've no hardware to test it on.
>
> Dave
>
> --- linux-2.6.4/arch/ppc/syslib/indirect_pci.c~ 2004-03-16 21:03:20.000000000 +0000
> +++ linux-2.6.4/arch/ppc/syslib/indirect_pci.c 2004-03-16 21:03:31.000000000 +0000
> @@ -44,8 +44,8 @@
> cfg_type = 1;
>
> PCI_CFG_OUT(hose->cfg_addr,
> - (0x80000000 | ((dev->bus->number - hose->bus_offset) << 16)
> - | (dev->devfn << 8) | ((offset & 0xfc) | cfg_type)));
> + (0x80000000 | ((bus->number - hose->bus_offset) << 16)
> + | (devfn << 8) | ((offset & 0xfc) | cfg_type)));
>
> /*
> * Note: the caller has already checked that offset is
There's this problem in 2 places. I've sent akpm a patch already that
fixes 'em both.
--
Tom Rini
http://gate.crashing.org/~trini/
prev parent reply other threads:[~2004-03-16 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-16 21:05 fix ppc compile Dave Jones
2004-03-16 21:20 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316212011.GA20967@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.