From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: overrides Date: Wed, 17 Mar 2004 21:08:15 +0100 Sender: cpufreq-bounces@www.linux.org.uk Message-ID: <20040317200815.GD287@elf.ucw.cz> References: <99F2150714F93F448942F9A9F112634C1126A1BF@txexmtae.amd.com> <20040317200051.GS28592@poupinou.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20040317200051.GS28592@poupinou.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cpufreq-bounces+glkc-cpufreq=gmane.org@www.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bruno Ducrot Cc: linux@dominikbrodowski.de, cpufreq@www.linux.org.uk On St 17-03-04 21:00:51, Bruno Ducrot wrote: > On Wed, Mar 17, 2004 at 12:01:49PM -0600, paul.devriendt@amd.com wrote: > > > -----Original Message----- > > > From: Bruno Ducrot [mailto:ducrot@poupinou.org] > > > Sent: Wednesday, March 17, 2004 10:04 AM > > > To: Pavel Machek > > > Cc: Dominik Brodowski; Cpufreq mailing list > > > Subject: Re: powernow-k8, more updates > > > > > > Why not just provide an override from userspace? > > > > The question of overrides is a difficult question. The > > theory is that BIOS provides a table of frequencies/ > > voltages that should be used for this system. This is > > because different processors vary on the frequencies > > that they support, and different processors have > > different voltages for the same frequency. Also, the > > platform may have additional restrictions, such as the > > need to restrict operation at higher frequencies when > > running on battery power. > > Then I think it's way better to kill all of this overriding stuff. > > If people want to override, then they have to reimplemente that > by themself. > > It's pretty easy by now to change that '#if 0' by '#if 1'... Yes, but please keep it in for now. It should be killed before mainline merge, but it is very helpfull for me just now. (Oh, and I think I actually cleaned code up while making overriding easier.) Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?]