From: Mike Anderson <andmike@us.ibm.com>
To: Kai Makisara <Kai.Makisara@kolumbus.fi>
Cc: Matthias Andree <ma+lscsi@dt.e-technik.uni-dortmund.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg KH <greg@kroah.com>
Subject: Re: 2.6.5-rc1 SCSI + st regressions (was: Linux 2.6.5-rc1)
Date: Wed, 17 Mar 2004 13:44:34 -0800 [thread overview]
Message-ID: <20040317214434.GF949@beaverton.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0403172312410.1093@kai.makisara.local>
Kai Makisara [Kai.Makisara@kolumbus.fi] wrote:
> if (!st_class_member) {
> printk(KERN_WARNING "st%d: class_simple_device_add failed\n",
> dev_num);
Could you change the if check to use IS_ERR(st_class_member) so in the
future if do_create_class_files return -E* we will not get a oops.
-andmike
--
Michael Anderson
andmike@us.ibm.com
next prev parent reply other threads:[~2004-03-17 21:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-16 5:58 Linux 2.6.5-rc1 Linus Torvalds
2004-03-16 16:19 ` Linux 2.6.5-rc1 (compile stats) John Cherry
2004-03-16 21:12 ` 2.6.5-rc1 SCSI + st regressions (was: Linux 2.6.5-rc1) Matthias Andree
2004-03-16 21:17 ` Matthew Wilcox
2004-03-16 21:56 ` Matthias Andree
2004-03-16 22:29 ` Matthew Wilcox
2004-03-17 20:35 ` Kai Makisara
2004-03-17 21:18 ` Kai Makisara
2004-03-17 21:43 ` Matthias Andree
2004-03-17 21:44 ` Mike Anderson [this message]
2004-03-17 22:25 ` Kai Makisara
2004-03-17 22:55 ` Greg KH
2004-03-17 23:04 ` Mike Anderson
2004-03-17 21:32 ` Matthias Andree
2004-03-17 21:32 ` Matthias Andree
2004-03-18 1:45 ` Andy Isaacson
2004-03-18 1:45 ` Andy Isaacson
2004-03-21 22:50 ` Linux 2.6.5-rc1 Peter Osterlund
2004-03-21 23:21 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040317214434.GF949@beaverton.ibm.com \
--to=andmike@us.ibm.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ma+lscsi@dt.e-technik.uni-dortmund.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.