All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: jim.houston@comcast.net
Cc: akpm@osdl.org, amitkale@emsyssoft.com, linux-kernel@vger.kernel.org
Subject: Re: Fixes for .cfi directives for x86_64 kgdb
Date: Thu, 18 Mar 2004 00:53:45 +0100	[thread overview]
Message-ID: <20040318005345.330abf19.ak@suse.de> (raw)
In-Reply-To: <m33c8788ac.fsf@new.localdomain>

On 17 Mar 2004 16:37:15 -0500
Jim Houston <jim.houston@comcast.net> wrote:

> 
> Hi Andi, Andrew, Amit,
> 
> The attached patch fixes the .cfi directives for the common_interrupt
> path for opteron.  It seems that the existing .cfi directives in this
> path only work by accident.
> 
> I spent yesterday decoding a stack by hand and looking at the
> dwarf unwind data using "readelf -wF".  I found that the  existing
> .cfi directives describe registers sharing the same stack addresses
> (not a good thing).
> 
> This patch makes the unwind data make sense and makes gdb/kgdb more
> likely to produce a useful stack traces.

Thanks. I applied it. The calling.h part gave rejects, but I applied it
by hand. It would be nice if you could check in the final kernel if I didn't
make a mistake.

-Andi



  reply	other threads:[~2004-03-17 23:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-17 21:37 Fixes for .cfi directives for x86_64 kgdb Jim Houston
2004-03-17 23:53 ` Andi Kleen [this message]
2004-03-18 16:51   ` Jim Houston
2004-03-19 13:17     ` Amit S. Kale
2004-03-19 19:23       ` Andi Kleen
2004-03-21 13:12         ` Amit S. Kale
2004-03-23  0:17 ` [PATCH]Call frame debug info for 2.6 kernel George Anzinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040318005345.330abf19.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=amitkale@emsyssoft.com \
    --cc=jim.houston@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.