From: Greg KH <greg@kroah.com>
To: Meelis Roos <mroos@linux.ee>
Cc: linux-kernel@vger.kernel.org
Subject: Re: whiteheat USB serial compile failure on PPC (2.6)
Date: Thu, 18 Mar 2004 17:00:15 -0800 [thread overview]
Message-ID: <20040319010015.GE19053@kroah.com> (raw)
In-Reply-To: <Pine.GSO.4.44.0403181205080.15185-100000@math.ut.ee>
On Thu, Mar 18, 2004 at 12:06:38PM +0200, Meelis Roos wrote:
> Whiteheat USB serial driver doesn't compile on PPC in 2.6 (in fact,
> hasn't compiled fo some time):
>
> drivers/usb/serial/whiteheat.c: In function `firm_setup_port':
> drivers/usb/serial/whiteheat.c:1225: error: `CMSPAR' undeclared (first use in this function)
> drivers/usb/serial/whiteheat.c:1225: error: (Each undeclared identifier is reported only once
> drivers/usb/serial/whiteheat.c:1225: error: for each function it appears in.)
Bah, looks like PPC doesn't ever define CMSPAR :(
How about adding something like:
#ifndef CMSPAR
#define CMSPAR 0
#endif
To the beginning of the driver like the cdc-acm.c driver does? If that
works, care to send me a patch?
thanks,
greg k-h
next prev parent reply other threads:[~2004-03-19 1:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-18 10:06 whiteheat USB serial compile failure on PPC (2.6) Meelis Roos
2004-03-19 1:00 ` Greg KH [this message]
2004-03-19 1:32 ` Paul Mackerras
2004-03-26 12:36 ` Meelis Roos
2004-03-26 20:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040319010015.GE19053@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.