From: Andrew Morton <akpm@osdl.org>
To: Andi Kleen <ak@suse.de>
Cc: linux-arch@vger.kernel.org, carlos@baldric.uwo.ca
Subject: Re: compat-signal-noarch-2004-01-29.patch again
Date: Fri, 19 Mar 2004 22:37:44 -0800 [thread overview]
Message-ID: <20040319223744.1f003f9f.akpm@osdl.org> (raw)
In-Reply-To: <20040320051519.780318b8.ak@suse.de>
Andi Kleen <ak@suse.de> wrote:
>
> On Fri, 19 Mar 2004 21:49:49 -0800
> Andrew Morton <akpm@osdl.org> wrote:
>
> >
> > This patch continues to hang around at Morton manor. last time it was
> > discussed Andi had issues with it and thing petered out.
> >
> > Can we please wrap this up one ay or the other?
>
> My only issue was the exporting of is_compat_task() to generic linux/compat.h
> If that is fixed (the code that does the is_compat_task is moved to arch/*
> again) then the change is fine and I would also likely use it for x86-64.
Cannot you define HAVE_ARCH_IS_COMPAT_TASK?
+#ifndef CONFIG_COMPAT
+/* Non-native task requiring compat... doesn't exist */
+#define is_compat_task(x) 0
+
+#else
+
#include <linux/stat.h>
#include <linux/param.h> /* for HZ */
+#include <linux/personality.h> /* Conditional process compat */
#include <linux/sem.h>
#include <asm/compat.h>
@@ -17,6 +23,11 @@
#define compat_jiffies_to_clock_t(x) \
(((unsigned long)(x) * COMPAT_USER_HZ) / HZ)
+/* Non-native task requiring compat */
+#ifndef HAVE_ARCH_IS_COMPAT_TASK
+#define is_compat_task(x) (x->personality == PER_LINUX32)
+#endif
+
next prev parent reply other threads:[~2004-03-20 6:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-20 5:49 compat-signal-noarch-2004-01-29.patch again Andrew Morton
2004-03-20 4:15 ` Andi Kleen
2004-03-20 6:37 ` Andrew Morton [this message]
2004-03-20 4:57 ` Andi Kleen
2004-03-20 7:42 ` Andrew Morton
2004-03-20 13:36 ` Matthew Wilcox
2004-03-20 20:20 ` Andrew Morton
2004-03-20 20:29 ` Matthew Wilcox
2004-03-20 20:31 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040319223744.1f003f9f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=carlos@baldric.uwo.ca \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.