From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by monty-python.gnu.org with archive (Exim 4.30) id 1B55Vz-00068X-VX for mharc-grub-devel@gnu.org; Sun, 21 Mar 2004 11:09:31 -0500 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B55Vx-00068I-RM for grub-devel@gnu.org; Sun, 21 Mar 2004 11:09:29 -0500 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B55VR-00061E-4l for grub-devel@gnu.org; Sun, 21 Mar 2004 11:09:28 -0500 Received: from [213.228.0.44] (helo=postfix3-1.free.fr) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B55VQ-0005zt-SR for grub-devel@gnu.org; Sun, 21 Mar 2004 11:08:56 -0500 Received: from openbrick.enbug.org (boitelle-1-82-66-127-114.fbx.proxad.net [82.66.127.114]) by postfix3-1.free.fr (Postfix) with ESMTP id 3B196C4236 for ; Sun, 21 Mar 2004 17:08:51 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by openbrick.enbug.org (Postfix) with ESMTP id 3C408177500 for ; Sun, 21 Mar 2004 19:09:11 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sun, 21 Mar 2004 17:11:52 +0100 User-Agent: KMail/1.5.3 References: <40595AA3.6000800@ciam.ru> <87brmr1eyq.fsf@marco.marco-g.com> <405CED3B.4090407@ciam.ru> In-Reply-To: <405CED3B.4090407@ciam.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200403211711.52377.okuji@enbug.org> Subject: Re: GRUB2: *BSD and more patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Mar 2004 16:09:30 -0000 On Sunday 21 March 2004 02:17, Sergey Matveychuk wrote: > @@ -716,9 +773,6 @@ pupa_util_biosdisk_get_pupa_dev (const c > return 0; > } > > - if (! S_ISBLK (st.st_mode)) > - return make_device_name (drive, -1, -1); > - This part is not good. The problem here is that we want to support installing GRUB into a normal file as well as a device file. So what I said to you was wrong. The check about a block device is sometimes very important. In FreeBSD, what is the right way to distinguish a device file from a normal file? > +#ifdef HAVE_MEMALIGN > p = memalign (align, size); > +#else > + p = malloc(size); > +#endif I don't agree on this one. Please implement memalign correctly. It's not so difficult. Probably it can be like this (not tested): p = malloc((size + align - 1) & ~(align - 1)); if (! p) return 0; return (p + align - 1) & ~(align - 1); It might be possible to find a better implementation, if you see glibc. BTW, I confirmed that you haven't assigned your copyright on GRUB to the FSF yet. For a GNU project, it is a custom to assign your copyright to the FSF, so that the FSF can fight instead of you in a court when someone claims that our software is illegal. Also, this step of a copyright assignment makes sure that your contribution will be free in freedom forever. So, would you like to sign a copyright assignment for GRUB? If you need more information, don't hesitate to ask me. We can talk privately if you want. Okuji