Re: Does struct qstr->name should be terminated ?

[Jan Hudec <bulb@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

On Tue, Mar 23, 2004 at 11:56:01 +0100, Jerome de Vivie wrote:
> 
> I've work with "struct qstr" for a while without bothering with the last 
> caracter: qstr->name[qstr->len]. I get oops from my module but after 
> investigation, i found lines in fs/namei.c that are using this caracter:
> 
> In do_rename:
>         /* unless the source is a directory trailing slashes give 
> -ENOTDIR */
>         if (!S_ISDIR(old_dentry->d_inode->i_mode)) {
>                 error = -ENOTDIR;
>                 if (oldnd.last.name[oldnd.last.len])
>                         goto exit4;
>                 if (newnd.last.name[newnd.last.len])
>                         goto exit4;
>         }
> 
> So, do i need to initialize this caracter when allocating new qstr ? Is 
> this caracter is used in other place in the VFS ?

I'd think that it's treated as a nomral string in quite a few places, so
it needs to be NUL terminated. (But not searched the sources.)

-------------------------------------------------------------------------------
						 Jan 'Bulb' Hudec <bulb@ucw.cz>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]