From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Matthew Wilcox <willy@debian.org>
Cc: Christoph Hellwig <hch@infradead.org>,
"Bagalkote, Sreenivas" <sreenib@lsil.com>,
'Jeff Garzik' <jgarzik@pobox.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH][RELEASE] megaraid 2.10.2 Driver
Date: Wed, 24 Mar 2004 17:39:15 -0300 [thread overview]
Message-ID: <20040324203915.GH5551@logos.cnet> (raw)
In-Reply-To: <20040324061553.GA13681@logos.cnet>
> On Tue, Mar 23, 2004 at 01:30:35PM +0000, Matthew Wilcox wrote:
> > On Tue, Mar 23, 2004 at 06:27:08AM +0000, Christoph Hellwig wrote:
> > > On Tue, Mar 23, 2004 at 12:45:43AM +0000, Matthew Wilcox wrote:
> > > > I don't think you understand how CONFIG_COMPAT works. x86-64 defines it
> > > > when it wants it:
> > >
> > > But not in 2.4, and this is a 2.4-only patch..
> >
> > It is? I didn't see that mentioned anywhere.
> >
> > Anyway, it's wrong to define LSI_CONFIG_COMPAT based solely on __x86_64__.
> > You'd also need to check IA32_EMULATION. Really, it would be simpler
> > to add CONFIG_COMPAT to 2.4.
I think is ok to use such XXX_CONFIG_COMPAT and #ifdef the register_ioctl calls
around it in the driver. Acceptable for 2.4. Comments?
I think you are right about checking for IA32_EMULATION too.
Does SPARC also define it?
The MPT fusion driver currently does:
#if (defined(__sparc__) && defined(__sparc_v9__)) || defined(__x86_64__)
#define MPT_CONFIG_COMPAT
#endif
Sreenivas: about the megaraid2 update, please work on the commentaries by Jeff.
next prev parent reply other threads:[~2004-03-24 19:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-23 0:02 [PATCH][RELEASE] megaraid 2.10.2 Driver Bagalkote, Sreenivas
2004-03-23 0:45 ` Matthew Wilcox
2004-03-23 6:27 ` Christoph Hellwig
2004-03-23 13:30 ` Matthew Wilcox
2004-03-23 13:36 ` Christoph Hellwig
[not found] ` <20040324061553.GA13681@logos.cnet>
2004-03-24 20:39 ` Marcelo Tosatti [this message]
2004-04-17 2:15 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2004-03-23 16:00 Bagalkote, Sreenivas
2004-03-22 22:56 Bagalkote, Sreenivas
2004-03-22 23:07 ` Jeff Garzik
2004-03-23 8:12 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040324203915.GH5551@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreenib@lsil.com \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.