Re: [PATCH] netdev - udevdb+dev.d changes

[Greg KH <greg@kroah.com>]

On Sun, Mar 28, 2004 at 08:48:40PM +0200, Kay Sievers wrote:
> Hey, Chris fixed the udevd hole and Treeve found the timestamp bug,
> so there was nothing left for me at the weekend :)
> 
> Here is a patch to change the netdev handling in the database and for
> the dev.d/ calls. I applies on top of the udevd.patch, cause klibc has
> no sysinfo().

Thanks, I've applied this now.

>  o netdev's are also put into our database now. I want this for the
>    udevruler gui to get a list of all handled devices.
>    All devices in the db are stamped with the system uptime value at
>    the creation time. 'udevinfo -d' prints it.

nice.

>  o the DEVPATH value is the key for udevdb, but if we rename
>    a netdev, the name is replaced in the kernel, so we add
>    the changed name to the db to match with the remove event.
>    
>    NOTE: The dev.d/ scripts still get the original name from the
>    hotplug call. Should we replace DEVPATH with the new name too?

Yeah, we should.

>  o We now only add a device to the db, if we have successfully created
>    the main node or successfully renamed a netdev. This is the main part
>    of the patch, cause I needed to clean the retval passing trough all
>    the functions used for node creation.
> 
>  o DEVNODE sounds a bit ugly for netdev's so I exported DEVNAME too.
>    Can we change the name?

Can you think of a better name?

>  o I've added a UDEV_NO_DEVD to possibly skip the script execution
>    and used it in udev-test.pl.
>    udevstart is the same horror now, if you have scripts with logging
>    statements in dev.d/ it takes minutes to finish, can we skip the
>    scripts here too?

No, a system will want to have those scripts run when udevstart is run
(at boot time.)  Otherwise how will devices get mounted, dbus messages,
etc. ?

>  o The get_device_type() function is changed to be more strict, cause
>    'udevinfo -a -p /block/' gets a class device for it and tries to
>    print the major/minor values.

I cut this out, as I had already applied it from a previous patch.

>  o bugfix, the RESULT value has now a working newline removal and a test
>    for this case.

Nice.

thanks a lot,

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel