From: Andi Kleen <ak@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org
Subject: Re: [PATCH 3/4] Consolidate sys32_select
Date: Sun, 4 Apr 2004 12:24:04 +0200 [thread overview]
Message-ID: <20040404122404.54329a2e.ak@suse.de> (raw)
In-Reply-To: <200404040222.41413.arnd@arndb.de>
On Sun, 4 Apr 2004 02:22:40 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> sys32_select has seven mostly but not exactly identical versions,
> so consolidate them as compat_sys_select. Based on the ppc64
> implementation, which most closely resembles sys_select.
>
> Passes relevant LTP test cases on x86_64.
I'm a bit dubious about LTP - often their test cases are very poor
and just check EFAULT behaviour. For testing it's better to just boot
a 32bit distribution and make sure that at least some X desktop
works. That said your patches look fine to me.
-Andi
next prev parent reply other threads:[~2004-04-04 10:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200404040204.03594.arnd@arndb.de>
2004-04-04 0:22 ` [PATCH 1/4] Consolidate sys32_readv and sys32_writev Arnd Bergmann
2004-04-04 0:22 ` [PATCH 2/4] Consolidate do_execve32 Arnd Bergmann
2004-04-13 18:45 ` Arun Sharma
2004-04-04 0:22 ` [PATCH 3/4] Consolidate sys32_select Arnd Bergmann
2004-04-04 10:24 ` Andi Kleen [this message]
2004-04-04 10:36 ` Arnd Bergmann
2004-04-04 11:04 ` Andi Kleen
2004-04-04 11:07 ` William Lee Irwin III
2004-04-04 22:51 ` Arnd Bergmann
2004-04-04 23:35 ` Andi Kleen
2004-04-04 23:41 ` Arnd Bergmann
2004-04-07 20:46 ` Arun Sharma
2004-04-08 8:22 ` Arnd Bergmann
2004-04-12 18:55 ` Arun Sharma
2004-04-04 0:22 ` [PATCH 4/4] Consolidate sys32_nfsservctl Arnd Bergmann
2004-04-16 16:00 consolidate compat readv/writev/execve/select/nfsservctl [v2] Arnd Bergmann
2004-04-16 16:05 ` [PATCH 3/4] Consolidate sys32_select Arnd Bergmann
2004-05-25 22:02 ` Martin Josefsson
2004-05-25 22:02 ` Martin Josefsson
2004-05-25 22:12 ` David S. Miller
2004-05-25 22:12 ` David S. Miller
2004-05-25 22:29 ` Martin Josefsson
2004-05-25 22:29 ` Martin Josefsson
-- strict thread matches above, loose matches on Subject: below --
2004-05-25 23:10 [PATCH 3/4] Consolidate sys32 select Arnd Bergmann
2004-05-25 23:10 ` Arnd Bergmann
2004-05-26 6:09 ` Martin Josefsson
2004-05-26 6:09 ` Martin Josefsson
2004-05-27 13:39 ` Arnd Bergmann
2004-05-27 13:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040404122404.54329a2e.ak@suse.de \
--to=ak@suse.de \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.